Update Chromium #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rome/... ScopedComPtr::CreateInstance() will soon be removed in favor of directly calling CoCreateInstance(). This change is a mechanical refactor from ScopedComPtr::CreateInstance() to CoCreateInstance(). BUG=638327 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng Review-Url: https://codereview.chromium.org/2894483002 Cr-Commit-Position: refs/heads/master@{#472710}
This CL introduces a new flag to let users revert it easier. BUG=624521 TEST=The added flag shows up in chrome://flags. Review-Url: https://codereview.chromium.org/2871243003 Cr-Commit-Position: refs/heads/master@{#472711}
Layout the Most Visited tiles to have them displayed as wanted in the ContentSuggestions view. It displays them as individual cells, maximum 4 by rows. BUG=707754 Review-Url: https://codereview.chromium.org/2887073002 Cr-Commit-Position: refs/heads/master@{#472712}
This is a mechanical change. BUG=687231 Review-Url: https://codereview.chromium.org/2888183003 Cr-Commit-Position: refs/heads/master@{#472713}
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/26dd16ea..a0a295e1 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel [email protected],[email protected],[email protected],[email protected] Review-Url: https://codereview.chromium.org/2890893002 Cr-Commit-Position: refs/heads/master@{#472714}
The AXSupportedAction enum is used to identify the appropriate string to use when a11y clients need to know the action that will occur on an a11y element when performing the default action, which is a click. Avoid any confusion with the AXActions an a11y element supports by renaming it. BUG=717846 Review-Url: https://codereview.chromium.org/2863703003 Cr-Commit-Position: refs/heads/master@{#472715}
The InkDrop hover was not properly being set when menus were being shown/dismissed and the event handler target was changing. BUG=719399 TEST=views_unittests --gtest_filter=*MenuButtonTest* Review-Url: https://codereview.chromium.org/2880623002 Cr-Commit-Position: refs/heads/master@{#472716}
It seems like the reinterpret_cast is not valid here and should be changed to std::copy or memcpy. Probably dereferencing the given pointer is undefined behavior: http://en.cppreference.com/w/cpp/language/reinterpret_cast BUG=722170 Review-Url: https://codereview.chromium.org/2876373002 Cr-Commit-Position: refs/heads/master@{#472717}
BUG=717091 [email protected] Review-Url: https://codereview.chromium.org/2889643003 Cr-Commit-Position: refs/heads/master@{#472718}
BUG=723285 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2887173002 Cr-Commit-Position: refs/heads/master@{#472719}
To copy a CSSTransitionData, we use CSSTransitionData::Create(o). However, this interface is inconsistent with many other classes that instead provide a clone method to do the same thing. This patch replaces the Create method with a Clone method to be consistent. BUG=628043 Review-Url: https://codereview.chromium.org/2886373002 Cr-Commit-Position: refs/heads/master@{#472720}
…ad-fetch BUG=443374 Review-Url: https://codereview.chromium.org/2891453005 Cr-Commit-Position: refs/heads/master@{#472721}
The javascript extracting the favicon urls from a page returns valid and invalid urls. The CRWWebController should only return the valid urls, as returning invalid url leads to a crash. BUG=720666 Review-Url: https://codereview.chromium.org/2880723002 Cr-Commit-Position: refs/heads/master@{#472722}
https://pdfium.googlesource.com/pdfium.git/+log/938f211b94ab..46abb66cb57d $ git log 938f211b9..46abb66cb --date=short --no-merges --format='%ad %ae %s' 2017-05-17 npm Use more static_cast in fpdfsdk 2017-05-17 npm Add font loading fuzzer 2017-05-17 dsinclair Shorten internal JS prefixes. 2017-05-16 tsepez CFX_UnownedPtr: check during assignment time as well. 2017-05-17 npm Add some missing keywords in ToUnicode 2017-05-17 npm Reland: Small fix in CPDF_TrueTypeFont load 2017-05-17 dsinclair Adding CXFA_Parse unittests Created with: roll-dep src/third_party/pdfium Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls [email protected] Change-Id: I4eaeb3c5f426117ed5615948622cce7d8ad63b37 Reviewed-on: https://chromium-review.googlesource.com/508284 Reviewed-by: <[email protected]> Commit-Queue: <[email protected]> Cr-Commit-Position: refs/heads/master@{#472723}
Many battor_agent failures on the waterfall could be solved by just retrying the command (e.g., StartTracing). Previously, the battor_agent retried reads and a select few BattOr control messages when they failed (e.g., INIT). This was incomplete, as there were many errors that did not result in retried BattOr control messages. This CL replaces this incomplete per-control-message retry logic with retry logic for entire battor_agent commands. This will make the battor_agent robust to intermittent failures of any BattOr control message. This required fixing the battor_agent overuse of the ambiguous "Unexpected Message" error. It also required replacing the timeout logic. BUG=699581 Review-Url: https://codereview.chromium.org/2826913002 Cr-Commit-Position: refs/heads/master@{#472724}
BUG=None Test=None CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2891653002 Cr-Commit-Position: refs/heads/master@{#472725}
BUG=699463 Change-Id: I5ce89aa56a4a061da133039943885a8fb40c46c0 Reviewed-on: https://chromium-review.googlesource.com/506670 Commit-Queue: Henrik Kjellander <[email protected]> Reviewed-by: Paweł Hajdan Jr. <[email protected]> Cr-Commit-Position: refs/heads/master@{#472726}
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/d76621c5ec84..dd9db5d3f658 $ git log d76621c5e..dd9db5d3f --date=short --no-merges --format='%ad %ae %s' 2017-05-17 kbr Pass False for fromSurface argument to Page.captureScreenshot. 2017-05-17 rnephew [Telemetry] Rename DisableBenchmark to PermenantlyDisableBenchmark in StoryExpectations 2017-05-17 sullivan Fix typo in api documentation 2017-05-17 kbr Expose browser command line via SystemInfo. 2017-05-17 sullivan Add documenation on the alert list JSON format. Created with: roll-dep src/third_party/catapult BUG=714058,711065,718635 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel [email protected] Change-Id: I7d0e18ec4ac4032ca270f38f6f406bf1357a33f0 Reviewed-on: https://chromium-review.googlesource.com/508260 Reviewed-by: <[email protected]> Commit-Queue: <[email protected]> Cr-Commit-Position: refs/heads/master@{#472727}
It inserted extra "r" directory when the display root full path begins with "/other". This was a regression introduced by 2839863002. https://codereview.chromium.org/2839863002/diff/240001/ui/file_manager/file_manager/foreground/js/ui/location_line.js TEST=manually verified in the Files app. BUG=723972 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2885143010 Cr-Commit-Position: refs/heads/master@{#472728}
Recoding purge-and-suspend memory growth introduced at crrev.com/2843373004 causes DCHECK errors. This CL removes them temporarily. BUG=722792, 670539, 635419 Review-Url: https://codereview.chromium.org/2893863002 Cr-Commit-Position: refs/heads/master@{#472729}
Move methods that were not virtual in ChromeClientImpl to ChromeClient and make them pure virtual, override in ChromeClientImpl. BUG=708879 Review-Url: https://codereview.chromium.org/2887633002 Cr-Commit-Position: refs/heads/master@{#472730}
This allows dictionary values to be efficiently moved out of the dictionary during iteration, allowing us to implement e.g. a faster MergeDictionary. Bug: Change-Id: I7580d2664568f5c3fb465f7d65926e3f36243f0d Reviewed-on: https://chromium-review.googlesource.com/505892 Commit-Queue: Daniel Cheng <[email protected]> Commit-Queue: Johan Tibell <[email protected]> Reviewed-by: Daniel Cheng <[email protected]> Cr-Commit-Position: refs/heads/master@{#472731}
This will allow us to transparently implement different image fetching logic (e.g. inlining the image data into the doodle config). And this logic doesn't really belong in the bridge anyway. BUG=719513 Review-Url: https://codereview.chromium.org/2886443002 Cr-Commit-Position: refs/heads/master@{#472732}
…ords. Remove unnecessary includes for ui/views/layout/layout_constants.h and do some refactoring to remove references to layout constants in chrome/browser/ui/views/passwords/*. This CL also improves the TestBrowserDialog tests for PasswordDialogViewTest and ManagePasswordsBubbleDialogViewTest. BUG=691897 Review-Url: https://codereview.chromium.org/2869683003 Cr-Commit-Position: refs/heads/master@{#472733}
ThemeSource used to cache the CSS for the NTP, which allowed it to serve it directly on the IO thread without hopping back to UI. However, https://codereview.chromium.org/2381093002 removed this cache, so the hop is necessary again. This CL slightly simplifies this by using the regular URLDataSource::TaskRunnerForRequestPath facilities instead of manually posting a task to the UI thread. BUG=none Review-Url: https://codereview.chromium.org/2886973003 Cr-Commit-Position: refs/heads/master@{#472734}
Trace on b/37638202 shows this something stuck in AudioOutputController::OnMoreData() so remove the lock in favor of an atomic op. BUG=none TEST=none CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2889613003 Cr-Commit-Position: refs/heads/master@{#472735}
This patch adds a protected rvalue reference setter for storage_only fields in ComputedStyle. This will allow handwritten setters to take advantage of move semantics (e.g. Length fields, pointer fields). Diff of generated files: https://gist.github.com/b5c155dcd25ab8a89259e1b33f5ece0b/revisions BUG=628043 Review-Url: https://codereview.chromium.org/2885333002 Cr-Commit-Position: refs/heads/master@{#472736}
In order to avoid special-purpose animation callbacks on the UI thread, this changes gamepad left-stick autoscroll to use the existing CC-impl-thread fling system instead. The browser sends a FlingStart gesture whenever the stick changes position, and the impl thread scrolls at a fixed velocity while the stick remains in place. This is plumbed through via a new "SyntheticAutoscroll" WebGestureDevice. I called it that instead of "Gamepad" because I plan to use this device type to drive middle-click autoscroll, drag-and-drop autoscroll, and selection out-of-bounds autoscroll, which are all similar indefinite fixed-velocity scrolls currently animating on the Blink main thread. This also leaves for now gamepad trigger autozoom using the old approach, I'll address it separately (still deciding whether to delete or support this subfeature). BUG=644488 [email protected],[email protected] (for mechanical changes in content/child/, chrome/android/javatests/) TEST=ContentViewScrollingTest.testJoystickScroll Change-Id: I41329e23899ffd90ab27440cfbf52a537f82a9a5 Reviewed-on: https://chromium-review.googlesource.com/502728 Reviewed-by: Alexandre Elias <[email protected]> Reviewed-by: Theresa Wellington <[email protected]> Reviewed-by: Selim Gurun <[email protected]> Reviewed-by: Sadrul Chowdhury <[email protected]> Reviewed-by: David Tapuska <[email protected]> Reviewed-by: Jinsuk Kim <[email protected]> Reviewed-by: Kent Tamura <[email protected]> Commit-Queue: Alexandre Elias <[email protected]> Cr-Commit-Position: refs/heads/master@{#472737}
…owing. content::PopupMenuHelper currently has protections for the RenderFrameHostImpl and the RenderWidgetHostViewMac being destroyed in the nested message loop that is run while showing the native NSMenu. However, PopupMenuHelper doesn't protect against the WebContentsViewMac (its owner) being destroyed. Since r470769, posted tasks may be executed while a menu is fading out. So it's possible for WebContentsViewMac to be destroyed sooner. Handle this case. Adds an integration test. Previously, destroying a tab wouldn't close a <select> menu open on it, now it does. So, without the fix, the test gets stuck waiting for the menu to close, but dismissing the menu (e.g. by clicking anywhere) would reproduce the crash in the linked bug. BUG=722830 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Review-Url: https://codereview.chromium.org/2888803002 Cr-Commit-Position: refs/heads/master@{#472738}
Clicking on it opens dedicated Node frontend. BUG=706916 Review-Url: https://codereview.chromium.org/2890973002 Cr-Commit-Position: refs/heads/master@{#472739}
New versions of Clang warns about this. BUG=724186 TBR=jbauman CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2892663004 Cr-Commit-Position: refs/heads/master@{#472932}
Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None Review-Url: https://codereview.chromium.org/2891853002 Cr-Commit-Position: refs/heads/master@{#472933}
Eliminate Shell::GetWmRootWindowForNewWindows(). Convert ShellPort::Get*RootWindow*() to aura::Window. (use Shell::GetPrimaryRootWindow() instead in many places) Convert ScopedRootWindowForNewWindows (etc.) to aura::Window. Convert WmShelf::ForWindow to take aura::Window. Cleanup some helpers and misc WmWindow usage. BUG=722551,687656 TEST=Automated; no behavior changes [email protected],[email protected] Review-Url: https://codereview.chromium.org/2886253002 Cr-Commit-Position: refs/heads/master@{#472934}
Fixes WebRtc tests timing out when run on debug builds. Bug: 723805 Change-Id: Ie4de21a6160b2bf649c2e2ee4c8f78fdea585dac Reviewed-on: https://chromium-review.googlesource.com/508792 Reviewed-by: Sami Kyöstilä <[email protected]> Commit-Queue: Sami Kyöstilä <[email protected]> Cr-Commit-Position: refs/heads/master@{#472935}
BUG=706105 [email protected], [email protected], [email protected] Review-Url: https://codereview.chromium.org/2882013002 . Cr-Commit-Position: refs/heads/master@{#472936}
suspends/resumes, respectively. BUG=672263 Review-Url: https://codereview.chromium.org/2889143002 Cr-Commit-Position: refs/heads/master@{#472937}
BUG=724163 Review-Url: https://codereview.chromium.org/2893983002 Cr-Commit-Position: refs/heads/master@{#472938}
Attempts to load the generated MHTML file after creating it for all tests in mhtml_generation_browsertest.cc. This allows for validation of its contents being well formed by verifying that the newly added console message is not reported. Also simplifies the checking for the MHTML generation succeeding by asserting from inside the generation call instead of having checks for test failure in multiple tests. BUG=672313 Review-Url: https://codereview.chromium.org/2866873002 Cr-Commit-Position: refs/heads/master@{#472939}
This CL adds a new target that all executables and shared libraries should depend on in preparation for adding a dependency on libc++. It also changes "component" to reference this new target instead of //build/config/sanitizers:deps. BUG=723069 [email protected],[email protected],[email protected] Review-Url: https://codereview.chromium.org/2888713003 Cr-Commit-Position: refs/heads/master@{#472940}
This change removes InputMethodEventHandler and instead sends the events to IME in WindowEventDispatcher::PreDispatchEvent(). This is a step towards unifying key event processing path in classic ash and mus+ash. BUG=719269 Review-Url: https://codereview.chromium.org/2872343003 Cr-Commit-Position: refs/heads/master@{#472941}
Since M58, we no longer write separate .logcat files for minidumps, so each minidump should have only a single file corresponding to it. This means we can simplify the code in CrashFileManager.cleanOutAllNonFreshMinidumpFiles(), which used to try to preserve .dmp and .logcat files together. BUG=none TEST=CrashFileManagerTest [email protected], [email protected] Review-Url: https://codereview.chromium.org/2885143007 Cr-Commit-Position: refs/heads/master@{#472942}
BUG=596760 Review-Url: https://codereview.chromium.org/2883353002 Cr-Commit-Position: refs/heads/master@{#472943}
Using wpt-import in Chromium e6bdad2. NOEXPORT=true Change-Id: I7a9023eaaadc6b7543c6adad30b807cabab212ff Reviewed-on: https://chromium-review.googlesource.com/508160 Reviewed-by: Jeff Carpenter <[email protected]> Commit-Queue: Quinten Yearsley <[email protected]> Cr-Commit-Position: refs/heads/master@{#472944}
Nuclear option to be reverted after the bots heal up. BUG=721245 [email protected] Review-Url: https://codereview.chromium.org/2897483003 . Cr-Commit-Position: refs/heads/master@{#472945}
BUG=668012 Review-Url: https://codereview.chromium.org/2892483004 Cr-Commit-Position: refs/heads/master@{#472946}
non-promotion. When a non composited sticky element is nested in a compositied ancestor which requires repaint on scroll, the sticky element should also be composited to have correct paint invalidation. TEST=compositing/overflow/non-composited-sticky-element-in-main-thread-scrolled-composited-ancestor.html; BUG=698358 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2845613002 Cr-Commit-Position: refs/heads/master@{#472947}
Initialize RendererSettings::enable_color_correct_rendering in RenderWidgetCompositor (previously we were just doing rasterization). Initialize cc:Display's output color spaces to sRGB, instead of leaving it uninitialized. BUG=713891 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2891503003 Cr-Commit-Position: refs/heads/master@{#472948}
we do not have the parse time. BUG=722947 Review-Url: https://codereview.chromium.org/2887133005 Cr-Commit-Position: refs/heads/master@{#472949}
Build: https://build.chromium.org/p/chromium.infra.cron/builders/rebaseline-o-matic/builds/694561 https://chromium.googlesource.com/chromium/src/+/c5f1b6126a765 BUG=646010 [email protected] Review-Url: https://codereview.chromium.org/2889683005 . Cr-Commit-Position: refs/heads/master@{#472950}
…address selected. Bug: 724172 Change-Id: I2642caf97aacbb8692f126af6b39c6178c8935cb Reviewed-on: https://chromium-review.googlesource.com/508808 Commit-Queue: Mathieu Perreault <[email protected]> Reviewed-by: Anthony Vallee-Dubois <[email protected]> Cr-Commit-Position: refs/heads/master@{#472951}
If, when a socket request completed asynchronously, the next socket request in the queue failed synchronously, ClientSocketPoolBase wouldn't continue to try to service other socket requests in the queue. As a result, the socket pools could end up with pending connect requests and free socket slots, but no ConnectJobs would be made to service them, if this happened 6 times in a row to a socket group. This was a relatively obscure issue, until H2 started depending on this path for sharing sessions when different domains map to the same IP. BUG=723748 Review-Url: https://codereview.chromium.org/2888623011 Cr-Commit-Position: refs/heads/master@{#472952}
The spec version check was added to blacklist servers that don't support icons. However, some servers like xfce4-notifyd list a spec version that doesn't have icons when the server actually does support icons. More context can be found on: https://codereview.chromium.org/2883983004/ BUG=676220 [email protected],[email protected] Review-Url: https://codereview.chromium.org/2891823002 Cr-Commit-Position: refs/heads/master@{#472953}
Before this patch, a missing favicon would result in a blank space on PaymentRequest UI on Android and no indication to the web developer that something went wrong. This patch adds a Mojo method PaymentRequestClient.WarnNoFavicon(), which is invoked by the browser and implemented in the renderer. The browser invokes the method when it finds no favicon and thus leaves a blank space on UI. The renderer implementation prints a warning in DevTools: "Favicon not found for PaymentRequest UI. User may not recognize the website." After this patch, a missing favicon on a page that's using PaymentRequest on Android results in a DevTools warning for the web developer. BUG=710002 Review-Url: https://codereview.chromium.org/2869893002 Cr-Commit-Position: refs/heads/master@{#472954}
This was a result of looking at GetPreferredSize overrides and asking whether they're really necessary. BUG=none Review-Url: https://codereview.chromium.org/2893573004 Cr-Commit-Position: refs/heads/master@{#472955}
BUG=717305 TEST=new tests Review-Url: https://codereview.chromium.org/2889453003 Cr-Commit-Position: refs/heads/master@{#472956}
Bug: 417782 Change-Id: I30be73eede1976bd94568ac03dceee9260b5b0c2 Reviewed-on: https://chromium-review.googlesource.com/507867 Reviewed-by: Steve Kobes <[email protected]> Commit-Queue: Christian Biesinger <[email protected]> Cr-Commit-Position: refs/heads/master@{#472957}
Callers are expected to show the currency code next to the amount, so strip all variations of the currency code from the output, when possible. Bug: 724150 Test: components_unittests Change-Id: I4cbe59f710df0375785cf10068b343d00cc2cc29 Reviewed-on: https://chromium-review.googlesource.com/508222 Reviewed-by: Rouslan Solomakhin <[email protected]> Commit-Queue: Mathieu Perreault <[email protected]> Cr-Commit-Position: refs/heads/master@{#472958}
Actions and body text are necessary and expected to be available for web notifications, so blacklist servers that don't support them. The conditions for using native notifications are described at the end of [1] (Google-only). [1] https://docs.google.com/a/google.com/document/d/1cqXPpIyCf1RaEYx9XCPjZbO6U5oDeyslajznnG9wd_U/edit?usp=sharing BUG=676220 [email protected],[email protected] Review-Url: https://codereview.chromium.org/2886903005 Cr-Commit-Position: refs/heads/master@{#472959}
vade
pushed a commit
that referenced
this pull request
May 24, 2017
…iew.chromium.org/2884623002/ ) Reason for revert: FindIt detected this CL as culprit. https://findit-for-me.appspot.com/waterfall/build-failure?url=https://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/builds/21215 Original issue's description: > Refactor backdrop that is currently used in the maximized mode. > > The maximized mode creates a backdrop window so that a user will not see the content of windows behind the top window, > in case it doesn't cover the entire window. (can happen if the maximize size is specified for example) > This CL generalizes the backdrop code used in maximize mode as to create the backdrop in the following scenarios: > > 1) Has a aura::client::kHasBackdrop property = true. > 2) BackdropDelegate::HasBackdrop(aura::Window* window) returns true. > 3) Active ARC window when the spoken feedback is enabled. > > > * Added delegate to check if the window should have a backdrop. > Maximized mode always puts a backdrop. > > * Added kHasBackdrop property for a window that needs a backdrop even in clamshell. > > * Move the accessibility feature implemented in exo's backbround. This > is useful and should be there even for non-arc/exo case. > > BUG=721646 > TEST=coverted by unit tests > > Review-Url: https://codereview.chromium.org/2884623002 > Cr-Commit-Position: refs/heads/master@{#472401} > Committed: https://chromium.googlesource.com/chromium/src/+/04936c54ed2396ae54cd824e24f11151e0e11948 [email protected],[email protected],[email protected],[email protected] # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=721646 Review-Url: https://codereview.chromium.org/2887103002 Cr-Commit-Position: refs/heads/master@{#472436}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.