fix!: remove FormLayout workaround for MS Edge < v16 (#8625)

vaadin · Feb 4, 2025 · 96ea5f5 · 96ea5f5
1 parent 2c4de76
commit 96ea5f5
Show file tree

Hide file tree

Showing 27 changed files with 1 addition and 4 deletions.
diff --git a/.../test/visual/lumo/screenshots/crud/baseline/ltr-editor-position-bottom-edit.png b/.../test/visual/lumo/screenshots/crud/baseline/ltr-editor-position-bottom-edit.png
diff --git a/.../test/visual/lumo/screenshots/crud/baseline/rtl-editor-position-bottom-edit.png b/.../test/visual/lumo/screenshots/crud/baseline/rtl-editor-position-bottom-edit.png
diff --git a/...t/visual/material/screenshots/crud/baseline/ltr-editor-position-bottom-edit.png b/...t/visual/material/screenshots/crud/baseline/ltr-editor-position-bottom-edit.png
diff --git a/...t/visual/material/screenshots/crud/baseline/rtl-editor-position-bottom-edit.png b/...t/visual/material/screenshots/crud/baseline/rtl-editor-position-bottom-edit.png
diff --git a/...st/visual/lumo/screenshots/custom-field/baseline/form-layout-item-text-area.png b/...st/visual/lumo/screenshots/custom-field/baseline/form-layout-item-text-area.png
diff --git a/...sual/lumo/screenshots/custom-field/baseline/form-layout-label-error-message.png b/...sual/lumo/screenshots/custom-field/baseline/form-layout-label-error-message.png
diff --git a/...isual/material/screenshots/custom-field/baseline/form-layout-item-text-area.png b/...isual/material/screenshots/custom-field/baseline/form-layout-item-text-area.png
diff --git a/.../material/screenshots/custom-field/baseline/form-layout-label-error-message.png b/.../material/screenshots/custom-field/baseline/form-layout-label-error-message.png
diff --git a/packages/form-layout/src/vaadin-form-layout-mixin.js b/packages/form-layout/src/vaadin-form-layout-mixin.js
@@ -354,10 +354,7 @@ export const FormLayoutMixin = (superClass) =>
           colspan = Math.min(colspan, this._columnCount);
 
           const childRatio = colspan / this._columnCount;
-
-          // Note: using 99.9% for 100% fixes rounding errors in MS Edge
-          // (< v16), otherwise the items might wrap, resizing is wobbly.
-          child.style.width = `calc(${childRatio * 99.9}% - ${1 - childRatio} * ${columnSpacing})`;
+          child.style.width = `calc(${childRatio * 100}% - ${1 - childRatio} * ${columnSpacing})`;
 
           if (col + colspan > this._columnCount) {
             // Too big to fit on this row, let's wrap it

diff --git a/packages/form-layout/test/visual/lumo/screenshots/form-layout/baseline/basic.png b/packages/form-layout/test/visual/lumo/screenshots/form-layout/baseline/basic.png
diff --git a/packages/form-layout/test/visual/lumo/screenshots/form-layout/baseline/br.png b/packages/form-layout/test/visual/lumo/screenshots/form-layout/baseline/br.png
diff --git a/packages/form-layout/test/visual/lumo/screenshots/form-layout/baseline/colspan.png b/packages/form-layout/test/visual/lumo/screenshots/form-layout/baseline/colspan.png
diff --git a/...orm-layout/test/visual/lumo/screenshots/form-layout/baseline/css-properties.png b/...orm-layout/test/visual/lumo/screenshots/form-layout/baseline/css-properties.png
diff --git a/...ut/test/visual/lumo/screenshots/form-layout/baseline/ltr-container-overflow.png b/...ut/test/visual/lumo/screenshots/form-layout/baseline/ltr-container-overflow.png
diff --git a/...isual/lumo/screenshots/form-layout/baseline/required-indicator-labels-aside.png b/...isual/lumo/screenshots/form-layout/baseline/required-indicator-labels-aside.png
diff --git a/...sual/lumo/screenshots/form-layout/baseline/required-indicator-labels-on-top.png b/...sual/lumo/screenshots/form-layout/baseline/required-indicator-labels-on-top.png
diff --git a/...m-layout/test/visual/lumo/screenshots/form-layout/baseline/responsive-steps.png b/...m-layout/test/visual/lumo/screenshots/form-layout/baseline/responsive-steps.png
diff --git a/...ut/test/visual/lumo/screenshots/form-layout/baseline/rtl-container-overflow.png b/...ut/test/visual/lumo/screenshots/form-layout/baseline/rtl-container-overflow.png
diff --git a/...form-layout/test/visual/lumo/screenshots/form-layout/baseline/single-column.png b/...form-layout/test/visual/lumo/screenshots/form-layout/baseline/single-column.png
diff --git a/...ges/form-layout/test/visual/material/screenshots/form-layout/baseline/basic.png b/...ges/form-layout/test/visual/material/screenshots/form-layout/baseline/basic.png
diff --git a/packages/form-layout/test/visual/material/screenshots/form-layout/baseline/br.png b/packages/form-layout/test/visual/material/screenshots/form-layout/baseline/br.png
diff --git a/...s/form-layout/test/visual/material/screenshots/form-layout/baseline/colspan.png b/...s/form-layout/test/visual/material/screenshots/form-layout/baseline/colspan.png
diff --git a/...layout/test/visual/material/screenshots/form-layout/baseline/css-properties.png b/...layout/test/visual/material/screenshots/form-layout/baseline/css-properties.png
diff --git a/...l/material/screenshots/form-layout/baseline/required-indicator-labels-aside.png b/...l/material/screenshots/form-layout/baseline/required-indicator-labels-aside.png
diff --git a/.../material/screenshots/form-layout/baseline/required-indicator-labels-on-top.png b/.../material/screenshots/form-layout/baseline/required-indicator-labels-on-top.png
diff --git a/...yout/test/visual/material/screenshots/form-layout/baseline/responsive-steps.png b/...yout/test/visual/material/screenshots/form-layout/baseline/responsive-steps.png
diff --git a/...-layout/test/visual/material/screenshots/form-layout/baseline/single-column.png b/...-layout/test/visual/material/screenshots/form-layout/baseline/single-column.png