Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Run tests using React 19 + 18 #2962

Merged
merged 7 commits into from
Feb 28, 2025
Merged

test: Run tests using React 19 + 18 #2962

merged 7 commits into from
Feb 28, 2025

Conversation

Artur-
Copy link
Member

@Artur- Artur- commented Dec 6, 2024 •
edited by platosha
Loading

Fixes #3282

@Artur- Artur- force-pushed the feature/react19 branch 3 times, most recently from 5d46fa2 to 6fd3ffd Compare December 10, 2024 09:06
@taefi taefi mentioned this pull request Dec 12, 2024
Closed
@Artur- Artur- force-pushed the feature/react19 branch 5 times, most recently from a527d68 to b890991 Compare January 1, 2025 12:56
@codecov Codecov
Copy link

codecov bot commented Jan 1, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.89%. Comparing base (24b3623) to head (d5f4c16).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2962   +/-   ##
=======================================
  Coverage   86.89%   86.89%           
=======================================
  Files         115      115           
  Lines        8300     8300           
  Branches     1269     1269           
=======================================
  Hits         7212     7212           
  Misses       1074     1074           
  Partials       14       14
Flag Coverage Δ
unittests 86.89% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Artur- Artur- force-pushed the feature/react19 branch 5 times, most recently from a8db705 to 0905654 Compare January 6, 2025 13:25
@Artur- Artur- changed the title chore: React 19 Run tests using React 19 Jan 9, 2025
@Artur- Artur- force-pushed the feature/react19 branch 5 times, most recently from e6da85d to d043d19 Compare January 10, 2025 07:19
@ZheSun88 ZheSun88 changed the base branch from main to update-validation-condition January 10, 2025 14:16
@ZheSun88 ZheSun88 changed the base branch from update-validation-condition to main January 10, 2025 14:34
@ZheSun88 ZheSun88 force-pushed the feature/react19 branch 4 times, most recently from 327061c to f86006b Compare January 10, 2025 14:57
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@Lodin
Copy link
Contributor

Lodin commented Feb 3, 2025

@Artur-, should this PR be closed since #3183 brought both React 19 and pinned dependencies?

@Artur-
Copy link
Member Author

Artur- commented Feb 3, 2025

If you have moved to build and test mainly using React 19, then this PR is no longer needed. How do you test with React 18?

@platosha platosha force-pushed the feature/react19 branch 2 times, most recently from 6b43581 to 13f4501 Compare February 28, 2025 10:50
@platosha platosha changed the title Run tests using React 19 test: Run tests using React 19 + 18 Feb 28, 2025
platosha
platosha reviewed Feb 28, 2025
View reviewed changes
.github/workflows/validation.yml
@@ -311,6 +305,66 @@ jobs:
packages/java/gradle-plugin/build/test-results/*
packages/java/gradle-plugin/build/reports/*
test-react-18:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The manual run to verify this change: https://github.com/vaadin/hilla/actions/runs/13588075190

@platosha platosha marked this pull request as ready for review February 28, 2025 12:47
@platosha platosha requested a review from Lodin February 28, 2025 12:47
@Lodin Lodin enabled auto-merge (squash) February 28, 2025 14:18
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@Lodin Lodin merged commit d28cdc3 into main Feb 28, 2025
15 checks passed
@Lodin Lodin deleted the feature/react19 branch February 28, 2025 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@platosha platosha platosha left review comments

@Lodin Lodin Lodin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Testing with React 18 + 19
3 participants
@Artur- @Lodin @platosha