no default shell in composite actions

.github/actions/buildbook/action.yml

@@ -11,13 +11,13 @@ inputs:
   jb-save:
     description: "Save the Jupyterbook Build (boolean)"
     required: true
+  token:
+    description: 'A GitHub Personal Access Token (for publishing)'
+    required: false
 
 runs:
   using: "composite"
   steps:
-    - name: Checkout repository
-      uses: actions/checkout@v2
-
     - name: Setup JupyterBook Cache
       if: ${{inputs.jb-cache}} == true
       uses: actions/cache@v2
@@ -29,14 +29,15 @@ runs:
     - uses: ./.github/actions/setupconda
 
     - name: Build JupyterBook
+      shell: bash -l {0}
       run: |
         ./scripts/deploy_website.sh
 
     - name: Publish to GitHub Pages
       if: ${{inputs.publish-to-gh}} == true
       uses: peaceiris/actions-gh-pages@v3
       with:
-        personal_token: ${{ secrets.GH_PAT }}
+        personal_token: ${{inputs.token}}
         publish_dir: book/_build/html
         publish_branch: gh-pages
 

.github/workflows/cron.yaml

@@ -9,14 +9,11 @@ on:
 jobs:
   build-and-test:
     runs-on: ubuntu-20.04
-    defaults:
-      run:
-        shell: bash -l {0}
 
     steps:
     - name: Checkout repository
       uses: actions/checkout@v2
-      
+
     - uses: ./.github/actions/buildbook
       with:
         jb-cache: true

.github/workflows/deploy.yaml

@@ -4,23 +4,24 @@ on:
   push:
     paths:
       - 'book/**'
+      - '{{ cookiecutter.repo_directory }}/**'
+      - 'scripts/**'
       - '.github/workflows/deploy.yaml'
+
     branches:
       - main
 
 jobs:
   build-and-deploy:
     runs-on: ubuntu-20.04
-    defaults:
-      run:
-        shell: bash -l {0}
 
     steps:
     - name: Checkout repository
       uses: actions/checkout@v2
-      
+
     - uses: ./.github/actions/buildbook
       with:
         jb-cache: true
         publish-to-gh: true
         jb-save: true
+        token:  ${{ secrets.GH_PAT }}

.github/workflows/manual.yaml

@@ -2,20 +2,15 @@ name: Build Without Cache
 
 on:
   workflow_dispatch:
-    # can maybe specify PR branch ref here?
-    # https://docs.github.com/en/actions/reference/events-that-trigger-workflows#example-workflow-configuration
 
 jobs:
   build-and-test:
     runs-on: ubuntu-20.04
-    defaults:
-      run:
-        shell: bash -l {0}
 
     steps:
     - name: Checkout repository
       uses: actions/checkout@v2
-      
+
     - uses: ./.github/actions/buildbook
       with:
         jb-cache: false

.github/workflows/netlifypreview.yaml

@@ -7,17 +7,14 @@ on:
 jobs:
   add-preview:
     runs-on: ubuntu-20.04
-    defaults:
-      run:
-        shell: bash -l {0}
     # This workflow accesses secrets and checks out a PR, so only run if labelled
     # https://securitylab.github.com/research/github-actions-preventing-pwn-requests/
     if: contains(github.event.pull_request.labels.*.name, 'preview')
 
     steps:
     - name: Checkout repository
       uses: actions/checkout@v2
-      
+
     - uses: ./.github/actions/buildbook
       with:
         jb-cache: true

.github/workflows/qaqc.yaml

@@ -4,6 +4,8 @@ on:
   pull_request:
     paths:
       - 'book/**'
+      - '{{ cookiecutter.repo_directory }}/**'
+      - 'scripts/**'
       - '.github/workflows/qaqc.yaml'
     branches:
       - main
@@ -34,6 +36,7 @@ jobs:
         check_filenames: true
         check_hidden: true
         only_warn: false
+        skip: '*.js'
 
     # borrowed from https://github.com/ProjectPythia/pythia-foundations/blob/main/.github/workflows/link-checker.yaml
     - name: Disable Notebook Execution

.github/workflows/test.yaml

@@ -2,28 +2,23 @@ name: Test
 
 on:
   pull_request_target:
-    types: [labeled, synchronize]
     paths:
       - 'book/**'
       - '.github/workflows/test.yaml'
+      - '{{ cookiecutter.repo_directory }}/**'
+      - 'scripts/**'
       - 'binder/**'
     branches:
       - main
 
 jobs:
   build-and-test:
     runs-on: ubuntu-20.04
-    defaults:
-      run:
-        shell: bash -l {0}
-    # This workflow accesses secrets and checks out a PR, so only run if labelled
-    # https://securitylab.github.com/research/github-actions-preventing-pwn-requests/
-    if: contains(github.event.pull_request.labels.*.name, 'preview')
 
     steps:
     - name: Checkout repository
       uses: actions/checkout@v2
-      
+
     - uses: ./.github/actions/buildbook
       with:
         jb-cache: true