Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sort: enable clippy::suspicious_open_options on OpenBSD #6851

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

lcheylus
Copy link
Contributor

On OpenBSD 7.6 (release October 2024), Rust version = 1.81.0 => we can now enable clippy::suspicious_open_options for lint with clippy.

Revert commit ee4392e


Tests OK with clippy (Rust 1.81 on OpenBSD 7.6) for sort:

$ cargo clippy --all-targets -puu_sort -- -W clippy::manual_string_new -D warnings
(...)
    Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.61s

On OpenBSD 7.6 (release October 2024), Rust version = 1.81.0 => we can now enable
clippy::suspicious_open_options.

Revert commit ee4392e

Signed-off-by: Laurent Cheylus <[email protected]>
Copy link

GNU testsuite comparison:

Skip an intermittent issue tests/rm/rm1 (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/timeout/timeout (passes in this run but fails in the 'main' branch)

@sylvestre sylvestre merged commit 17fee51 into uutils:main Nov 14, 2024
62 of 65 checks passed
@lcheylus lcheylus deleted the openbsd-suspicious_open_options branch November 14, 2024 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants