-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
du: Avoid unnecessary call to GetFileInformationByHandleEx #6841
Open
jesseschalken
wants to merge
1
commit into
uutils:main
Choose a base branch
from
jesseschalken:avoid-unnecessary-get_size_on_disk
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
du: Avoid unnecessary call to GetFileInformationByHandleEx #6841
jesseschalken
wants to merge
1
commit into
uutils:main
from
jesseschalken:avoid-unnecessary-get_size_on_disk
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jesseschalken
changed the title
Avoid unnecessary call to GetFileInformationByHandleEx
du: Avoid unnecessary call to GetFileInformationByHandleEx
Nov 3, 2024
jesseschalken
force-pushed
the
avoid-unnecessary-get_size_on_disk
branch
from
November 3, 2024 12:59
9baeb9c
to
ef082f2
Compare
jesseschalken
force-pushed
the
avoid-unnecessary-get_size_on_disk
branch
2 times, most recently
from
November 3, 2024 14:03
cbc106b
to
cacc8c5
Compare
GNU testsuite comparison:
|
sylvestre
reviewed
Nov 4, 2024
let file_info = get_file_info(path); | ||
|
||
Ok(Self { | ||
path: path.to_path_buf(), | ||
is_dir: metadata.is_dir(), | ||
size: if path.is_dir() { 0 } else { metadata.len() }, | ||
blocks: size_on_disk / 1024 * 2, | ||
size: if options.apparent_size { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
almost duplicate code, maybe move it above the windows / not windows
sylvestre
force-pushed
the
avoid-unnecessary-get_size_on_disk
branch
from
November 11, 2024 11:48
cacc8c5
to
f77bb24
Compare
GNU testsuite comparison:
|
some tests fails:
|
ping ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't need to call
GetFileInformationByHandleEx
to track blocks if--apparent-size
was passed.This removes
blocks
fromStat
and instead moves the handling of--apparent-size
intoStat::new
so it can avoid callingGetFileInformationByHandleEx
if necessary.~1.65x speed up on my test folder.
Before
After