-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgraded metadata lookup for backwards compatibility, added option to input metadata manually #179
Open
PriyankaKetkarBNL
wants to merge
16
commits into
main
Choose a base branch
from
Issue178_FixLoadRun
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…written out during a scan
…here epoch defined.
…rched in Tiled for backwards compatibility
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issue #178.
mdLookup
dictionary was updated so that beamline metaddata key names can be entered as a list instead of single value (or two values in the case ofsecondary_lookup table
). Sets up infrastructure for backwards compatibility with respect to key names used historically at the beamline.secondary_lookup
dictionary was removed, as all historical key names are consolidated intomdLookup
. These changes were propagated to the code where Tiled is searched for metadata keys as well as in the construction of reverse lookup table (reverse_lut
) inloadRun
. These changes were tested for scan IDs 92849, 93065, and 91175, which include scans from before and after the beamline codebase upgrades in January 2025.Additionally,
mdManual
input was added intoloadRun
function so that metadata values can be entered manually in case they were not originally written out with the scan. My understanding is that the currentcoords
input cannot take more qualitative single-value entries (e.g.,{"sample_notes": "details"}
) that are meant to be stored inattrs
. If it makes sense, I could think of how to consolidate these two inputs.