Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Warn on dynamic function with surrounding text #1426

Merged
merged 1 commit into from
Mar 21, 2025

Conversation

chrisjsewell
Copy link
Member

@chrisjsewell chrisjsewell commented Mar 19, 2025

Currently, for an item in a list field, with a dynamic function plus other text, the other text will be silently omitted, e.g.

.. spec:: TEST_1
    :id: TEST_1
    :tags: test_1a;test_1b;[[copy('title')]]omitted

A warning is now emitted about this

Currently, for an item in a list field, with a dynamic function plus other text, the other text will be silently omitted, e.g.

```restructuredtext
.. spec:: TEST_1
    🆔 TEST_1
    :tags: test_1a;test_1b;[[copy('title')]]omitted
```

A warning is now emmited to war about this
@chrisjsewell chrisjsewell requested review from ubmarco and danwos March 19, 2025 17:15
Copy link

codecov bot commented Mar 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.55%. Comparing base (4e10030) to head (12fb6c0).
Report is 123 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1426      +/-   ##
==========================================
+ Coverage   86.87%   88.55%   +1.67%     
==========================================
  Files          56       60       +4     
  Lines        6532     7236     +704     
==========================================
+ Hits         5675     6408     +733     
+ Misses        857      828      -29     
Flag Coverage Δ
pytests 88.55% <100.00%> (+1.67%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@chrisjsewell chrisjsewell merged commit e4c16c8 into master Mar 21, 2025
18 checks passed
@chrisjsewell chrisjsewell deleted the warn-df-in-list branch March 21, 2025 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants