-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Aor jet #690
Aor jet #690
Conversation
Please don't merge it just yet: I want to try adding little-endian optimization |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this will do
I included Looks like the speed up comes from removing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Those #define
's are vestigial, and this codebase is little-endian only. So you can just use your little-endian version and drop the other one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your naming conventions don't matching u3's suffix patterns. The name suffix should match the type of the variable, regardless of whether it's a pointer: c3_y -> foo_y
, c3_w foo_w
, &c.
++aor
jet. 10x speed up with this input: