u3: adds deletion to HAMT #629
Open
+227
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkg/noun/hashtable.c
Outdated
|
|
||
|
|
||
|
|
||
| /** TODO: this has a bug where the freeing a hamt that this has been called with failes |
There was a problem hiding this comment.
@joemfb This seems like something that should be addressed before merging.
There was a problem hiding this comment.
I think it's obsolete, but need to confirm before removing it. These changes need a full review, didn't want them to sneak in.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ported from #617 for independent review, with some test cleanup.