-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
conn: do not chdir for conn.sock #581
Closed
Closed
Commits on Jan 5, 2024
-
conn: do not chdir for conn.sock
Instead, we create the socket in a temporary directory - TMPDIR if it is not too long, or else /tmp. The directory is made via `mkdtemp` with the template `urbit-XXXXXX`. The socket is located there (getting around the length limit) and `$pier/.urb/conn.sock` is symlinked to it. Replaces calls to uv_strerror with strerror for system calls; the former does not print system call errors properly.
Configuration menu - View commit details
-
Copy full SHA for a2b707d - Browse repository at this point
Copy the full SHA a2b707dView commit details -
Configuration menu - View commit details
-
Copy full SHA for ee14650 - Browse repository at this point
Copy the full SHA ee14650View commit details -
Configuration menu - View commit details
-
Copy full SHA for 098d25c - Browse repository at this point
Copy the full SHA 098d25cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6a3cf10 - Browse repository at this point
Copy the full SHA 6a3cf10View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4f49b0c - Browse repository at this point
Copy the full SHA 4f49b0cView commit details -
The pier socket link is predictable; no information is conveyed by printing it.
Configuration menu - View commit details
-
Copy full SHA for 69711d4 - Browse repository at this point
Copy the full SHA 69711d4View commit details
Commits on Jan 8, 2024
-
conn: move listen after path setup
Now uv_close is never needed as part of failure cleanup. N.B. this can be moved before the close to keep the cleanup logic stacked.
Configuration menu - View commit details
-
Copy full SHA for c32a8c3 - Browse repository at this point
Copy the full SHA c32a8c3View commit details -
Configuration menu - View commit details
-
Copy full SHA for d87a67e - Browse repository at this point
Copy the full SHA d87a67eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 105073b - Browse repository at this point
Copy the full SHA 105073bView commit details -
Configuration menu - View commit details
-
Copy full SHA for fa829a5 - Browse repository at this point
Copy the full SHA fa829a5View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.