Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

conn: do not chdir for conn.sock #581

Closed
wants to merge 10 commits into from
Closed

Commits on Jan 5, 2024

  1. conn: do not chdir for conn.sock

    Instead, we create the socket in a temporary directory - TMPDIR if it is
    not too long, or else /tmp. The directory is made via `mkdtemp` with the
    template `urbit-XXXXXX`. The socket is located there (getting around the
    length limit) and `$pier/.urb/conn.sock` is symlinked to it.
    
    Replaces calls to uv_strerror with strerror for system calls; the former
    does not print system call errors properly.
    mrdomino committed Jan 5, 2024
    Configuration menu
    Copy the full SHA
    a2b707d View commit details
    Browse the repository at this point in the history
  2. conn: cleanup

    mrdomino committed Jan 5, 2024
    Configuration menu
    Copy the full SHA
    ee14650 View commit details
    Browse the repository at this point in the history
  3. conn: always close fid_i

    mrdomino committed Jan 5, 2024
    Configuration menu
    Copy the full SHA
    098d25c View commit details
    Browse the repository at this point in the history
  4. conn: rm tmpdir

    mrdomino committed Jan 5, 2024
    Configuration menu
    Copy the full SHA
    6a3cf10 View commit details
    Browse the repository at this point in the history
  5. conn: SOCK_PATH_MAX

    mrdomino committed Jan 5, 2024
    Configuration menu
    Copy the full SHA
    4f49b0c View commit details
    Browse the repository at this point in the history
  6. conn: only show tmp socket

    The pier socket link is predictable; no information is conveyed by
    printing it.
    mrdomino committed Jan 5, 2024
    Configuration menu
    Copy the full SHA
    69711d4 View commit details
    Browse the repository at this point in the history

Commits on Jan 8, 2024

  1. conn: move listen after path setup

    Now uv_close is never needed as part of failure cleanup. N.B. this can
    be moved before the close to keep the cleanup logic stacked.
    mrdomino committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    c32a8c3 View commit details
    Browse the repository at this point in the history
  2. conn: remove trailing / from TMPDIR

    Also handles 0-length TMPDIR.
    mrdomino committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    d87a67e View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    105073b View commit details
    Browse the repository at this point in the history
  4. conn: whitespace

    mrdomino committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    fa829a5 View commit details
    Browse the repository at this point in the history