fix: skip parseESlint
if eslint filepath is a js file
#510
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Focusing on the same bug in #498 .
If
eslintrc.filepath
ends with "js", it will generate a javascript file (which is add in #494 ), however theparseESlint
function still treat it as JSON file, which triggers an error.In this PR,
parseESlint
returns{}
if filepath ends with "js", instead of theString.replace()
method used in #498 . Parsing is skipped in non-json mode.If I understand correctly, skipping the parsing of previously generated eslint files would only have an impact on artifacts when the generated file was manually modified or the scope of automatic imports is narrowed. I'm not sure if resolve work fine, since I haven't use them.
Linked Issues
null
Additional context
Maybe it will be better to be able to "import" it, but I cannot find an elegant way to do that.