Feature/infinite moving cards #61
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Hi @sivareddyuppathi,
Thanks for providing this component.
After reviewing, I found that this component seems like another implementation of Marquee component we already have. It has the same functionality and features.
https://inspira-ui.com/components/marquee
I think there is no need to have 2 components which are exactly similar in features & functionality.
| @@ -0,0 +1,32 @@ | |||
| --- | |||
| title: Infinite Moving Cards | |||
| description: A customizable group of cards that move infinitely in a loop. Made with Framer Motion and Tailwind CSS. | |||
There was a problem hiding this comment.
We are not using Framer Motion.
| @@ -50,7 +50,7 @@ export default withNuxt( | |||
| "import/newline-after-import": "error", | |||
| "import/no-duplicates": "error", | |||
| "import/no-unresolved": "off", //Need eslint-import-resolver-typescript, waiting for flatconfig and error fix on package side | |||
| "func-style": ["error", "declaration"], | |||
| "func-style": ["error", "declaration", { allowArrowFunctions: true }], | |||
There was a problem hiding this comment.
Arrow functions are not allowed.
|
Yeah you're right @rahul-vashishtha I'm closing this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.