Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add compare component #60

Merged
merged 8 commits into from
Nov 9, 2024
Merged

Conversation

atif0075
Copy link
Contributor

@atif0075 atif0075 commented Nov 9, 2024

implementation of https://ui.aceternity.com/components/compare in nuxt with more flexibility and freedom with slots.

Copy link
Member

@rahul-vashishtha rahul-vashishtha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can make use of v-bind in css instead of adding extra variables through style. This will make code more clean and will avoid the conflicts in users code, in case of same variable names.

</script>

<style scoped>
.star-field {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These properties and some of the other properties can directly be used as tailwind class. absolute inset-0 overflow-hidden

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think the v-bind would help in this case because v-bind can only access component-level reactive properties, and cannot bind to individual elements generated within a v-for loop(as per my knowledge) or I am not getting your query properly.
For now, I've added the prefix inspira to variable names to avoid naming conflicts.

@rahul-vashishtha rahul-vashishtha merged commit 169a5b8 into unovue:main Nov 9, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants