Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Governance): Added proposal to create Linear sablier stream #15404

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

blahkheart
Copy link
Contributor

Description

  • Added proposal to create Linear sablier stream
  • Added updated script for arbitrum l1-l2 messaging proposal using arbitrum sdk v4

Issues

Fixes #
Refs #

Checklist:

  • 1 PR, 1 purpose: my Pull Request applies to a single purpose
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the docs to reflect my changes if applicable
  • I have added tests (and stories for frontend components) that prove my fix is effective or that my feature works
  • I have performed a self-review of my own code
  • If my code involves visual changes, I am adding applicable screenshots to this thread

Release Note Draft Snippet

- Added updated arbitrum l1-l2 messaging proposal for arbitrum sdk v4
@cla-bot cla-bot bot added the cla-signed label Jan 30, 2025
Copy link

vercel bot commented Jan 30, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
unlock-static-site ⬜️ Ignored (Inspect) Feb 18, 2025 3:20pm
unlock-storybook ⬜️ Ignored (Inspect) Feb 18, 2025 3:20pm

@blahkheart
Copy link
Contributor Author

@julien51 @clemsos Please review. I'm having some problems with the proposal failing during the simulation with an error message "underlying transaction reverted". I'm not sure why that's happening since the approve call for Sablier contract works fine when I isolate it, so I need some help investigating the cause of the revert.
Resources:
https://docs.tally.xyz/knowledge-base/proposals/creating-proposals/custom-actions/streaming-payments-with-sablier
https://docs.sablier.com/guides/lockup/deployments
https://docs.sablier.com/guides/lockup/examples/create-stream/lockup-linear

@blahkheart
Copy link
Contributor Author

@clemsos Please also have a look at the updated proposal script to execute arbitrum l1 to l2 messaging using the arbitrum SDK v4 as discussed in the discord thread here https://discord.com/channels/462280183425138719/1311097248758763560

@julien51 julien51 requested review from julien51 and clemsos February 20, 2025 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant