Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(unlock-app): making crosschain hook agnostic #15074

Merged
merged 27 commits into from
Nov 13, 2024

Conversation

julien51
Copy link
Member

@julien51 julien51 commented Nov 13, 2024

Description

I am trying to extract logic which can be re-used with other providers (relay.link) vs logc that's specific.

Issues

Fixes #
Refs #

Checklist:

  • 1 PR, 1 purpose: my Pull Request applies to a single purpose
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the docs to reflect my changes if applicable
  • I have added tests (and stories for frontend components) that prove my fix is effective or that my feature works
  • I have performed a self-review of my own code
  • If my code involves visual changes, I am adding applicable screenshots to this thread

Release Note Draft Snippet

@julien51 julien51 requested a review from 0xTxbi November 13, 2024 19:53
@cla-bot cla-bot bot added the cla-signed label Nov 13, 2024
@julien51 julien51 changed the title Use crosschain agnostic feat(unlock-app): making crosschain hook agnostic Nov 13, 2024
@julien51 julien51 merged commit 5dab6ee into master Nov 13, 2024
13 checks passed
@julien51 julien51 deleted the use-crosschain-agnostic branch November 13, 2024 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants