Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(smart-contracts): wrong token id after a key was burnt #15071

Merged
merged 5 commits into from
Nov 13, 2024

Conversation

clemsos
Copy link
Member

@clemsos clemsos commented Nov 13, 2024

Description

This PR fixes a bug in token id assignation after burning a key. As the token id is based on the existing supply of keys and the burn function decrease that supply, the token id calculations should take into account the number of keys that have been burnt.

Issues

Fixes #
Refs #

Checklist:

  • 1 PR, 1 purpose: my Pull Request applies to a single purpose
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the docs to reflect my changes if applicable
  • I have added tests (and stories for frontend components) that prove my fix is effective or that my feature works
  • I have performed a self-review of my own code
  • If my code involves visual changes, I am adding applicable screenshots to this thread

Release Note Draft Snippet

@clemsos clemsos merged commit 43d5cf8 into master Nov 13, 2024
13 checks passed
@clemsos clemsos deleted the burnt-tokens-count branch November 13, 2024 16:07
clemsos added a commit that referenced this pull request Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants