Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(locksmith) Single web3service locksmith #15051

Merged
merged 6 commits into from
Nov 12, 2024

Conversation

julien51
Copy link
Member

Description

I was investigating some issues yesterday and realized we were wasting a lot of RPC requests because we instantiate a new web3 service every time.
With this change we should now be re-using an instance.

Checklist:

  • 1 PR, 1 purpose: my Pull Request applies to a single purpose
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the docs to reflect my changes if applicable
  • I have added tests (and stories for frontend components) that prove my fix is effective or that my feature works
  • I have performed a self-review of my own code
  • If my code involves visual changes, I am adding applicable screenshots to this thread

Release Note Draft Snippet

@cla-bot cla-bot bot added the cla-signed label Nov 11, 2024
@julien51
Copy link
Member Author

We should probably do something similar in unlock-app in fact. The reason is that unlock-js has a caching mechanism that means we don't need to do as many RPC requests.

@julien51 julien51 requested a review from 0xTxbi November 11, 2024 19:46
@julien51 julien51 merged commit b9ada14 into master Nov 12, 2024
14 checks passed
@julien51 julien51 deleted the single-web3service-locksmith branch November 12, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants