Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(unlock-app): Unlock legacy accounts migration UX improvements and cleanup #15048

Merged
merged 6 commits into from
Nov 10, 2024

Conversation

0xTxbi
Copy link
Member

@0xTxbi 0xTxbi commented Nov 8, 2024

Description

This PR introduces changes that improve the migration process/flow.

Issues

Fixes #
Refs #14858

Checklist:

  • 1 PR, 1 purpose: my Pull Request applies to a single purpose
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the docs to reflect my changes if applicable
  • I have added tests (and stories for frontend components) that prove my fix is effective or that my feature works
  • I have performed a self-review of my own code
  • If my code involves visual changes, I am adding applicable screenshots to this thread

@0xTxbi 0xTxbi requested a review from julien51 November 8, 2024 22:38
@cla-bot cla-bot bot added the cla-signed label Nov 8, 2024
@0xTxbi 0xTxbi changed the title feature(unlock-app): Unlock legacy accounts UX improvements and cleanup feature(unlock-app): Unlock legacy accounts migration UX improvements and cleanup Nov 8, 2024
@julien51 julien51 merged commit 7deae2a into master Nov 10, 2024
13 checks passed
@julien51 julien51 deleted the account-migration-cleanup-ux branch November 10, 2024 23:35
julien51 pushed a commit that referenced this pull request Nov 10, 2024
… and cleanup (#15048)

* improve popup appearance

* exempt google sign in page from dashboard layout

* track privy connection status and properly disable migration step

* improve google sign in disabled appearance

* cleanup logs

* cleanup logs
julien51 added a commit that referenced this pull request Nov 11, 2024
* Manual deploy as of commit:07497725077e42c8997d80b7efb565e671103688

* feature(unlock-app): Unlock legacy accounts migration UX improvements and cleanup (#15048)

* improve popup appearance

* exempt google sign in page from dashboard layout

* track privy connection status and properly disable migration step

* improve google sign in disabled appearance

* cleanup logs

* cleanup logs

* fix(unlock-app): triggering event when session is still valid

---------

Co-authored-by: txbì <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants