Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(smart-contracts): remember referrer for renewals #15017

Merged
merged 19 commits into from
Nov 12, 2024
Merged

Conversation

clemsos
Copy link
Member

@clemsos clemsos commented Nov 4, 2024

Description

Adds a way to remember the referrer used when first purchasing a key then reuse it when renewing it.

Issues

Fixes #13487
Refs #

Checklist:

  • 1 PR, 1 purpose: my Pull Request applies to a single purpose
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the docs to reflect my changes if applicable
  • I have added tests (and stories for frontend components) that prove my fix is effective or that my feature works
  • I have performed a self-review of my own code
  • If my code involves visual changes, I am adding applicable screenshots to this thread

Release Note Draft Snippet

@clemsos clemsos requested a review from julien51 November 4, 2024 15:52
@cla-bot cla-bot bot added the cla-signed label Nov 4, 2024
Copy link
Member

@julien51 julien51 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one minor change and then LGTM!

if (_originalTokens[_tokenId] != tokenAddress) {
_originalTokens[_tokenId] = tokenAddress;
}
function _recordTokenTerms(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@clemsos How will tht work for upgraded contracts though?

@julien51 julien51 merged commit 9c79424 into master Nov 12, 2024
13 checks passed
@julien51 julien51 deleted the remember-referrer branch November 12, 2024 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Keep track of referrer address for renewals
2 participants