Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve constructor judgments for objects requiring more than one argument in LLRT #126

Open
1 task
nabetti1720 opened this issue May 15, 2024 · 5 comments

Comments

@nabetti1720
Copy link

Describe the feature

Constructors of objects that require more than one argument, such as Request and URL, are treated as failures.

      {
        "name": "api.Request.Request",
        "info": {
          "code": "bcd.testConstructor('Request')",
          "exposure": "Window"
        },
        "result": null,
        "message": "threw TypeError: Error calling function with 0 argument(s) while 1 where expected"
      },

I think I understand where I need to correct the problem, and I would like to raise the PR after this.

Additional information

  • Would you be willing to help implement this feature?
@ascorbic
Copy link
Collaborator

Hey. This would be best contributed upstream: https://github.com/openwebdocs/mdn-bcd-collector/

@nabetti1720
Copy link
Author

I'm sorry. I will close the PR here and go to upstream to submit a PR.

@nabetti1720
Copy link
Author

Hi, @ascorbic ,
As you said, I have PR'd it to upstream, but they can't seem to get it merged.

And hi, @queengooborg .
You seem to have the authority to merge on the upstream side, do you know what the problem is with the PR I have implemented?
I am trying to solve this problem with the same approach that was previously addressed by workerd.
I guess we will have to wait...

@nabetti1720
Copy link
Author

Hi @ascorbic , We were able to have them merged on the upstream side.
Is there anything I should do in this project?

@nabetti1720
Copy link
Author

Hi @ascorbic , Are there any plans to merge upstream modifications in the near future?
Or will it be after upstream has moved further forward?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants