Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update constructor judgments of LLRT #1463

Conversation

nabetti1720
Copy link
Contributor

@nabetti1720 nabetti1720 commented May 15, 2024

In LLRT, this corresponds to the following message that occurs in the execution of the constructor of an object that requires one or more arguments.

See also. unjs/runtime-compat#126

      {
        "name": "api.Request.Request",
        "info": {
          "code": "bcd.testConstructor('Request')",
          "exposure": "Window"
        },
        "result": null,
        "message": "threw TypeError: Error calling function with 0 argument(s) while 1 where expected"
      },

Execution results in LLRT (cli mode):

% ./llrt -v                              
LLRT (darwin arm64) 0.1.14-beta

% ./llrt -e "const req = new Request();"                     
TypeError: Error calling function with 0 argument(s) while 1 where expected
    at <eval> (eval_script:1:13)

@nabetti1720 nabetti1720 force-pushed the feat/update-constructor-judgments-of-llrt branch from 435c893 to 30b622f Compare May 16, 2024 15:35
@nabetti1720 nabetti1720 force-pushed the feat/update-constructor-judgments-of-llrt branch from 30b622f to 03592f5 Compare May 18, 2024 02:10
@queengooborg
Copy link
Member

Hi there, thanks for your PR! It looks like your commits are not signed, which is a requirement for this repository. If you're unable to set up signing locally, you can also make this change directly from the GitHub web interface and it will be signed automatically!

@nabetti1720
Copy link
Contributor Author

Hi there, thanks for your PR! It looks like your commits are not signed, which is a requirement for this repository. If you're unable to set up signing locally, you can also make this change directly from the GitHub web interface and it will be signed automatically!

Thank you for telling us why it is not merged.
And I apologize for not understanding the requirements of this repository.

Due to the fact that I don't know how to put an author's name on the current commit, and fortunately it is a small correction, I am going to withdraw it for now.
Once again, we are pleased to promote this project with a prominent commitment.

@nabetti1720 nabetti1720 deleted the feat/update-constructor-judgments-of-llrt branch May 18, 2024 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants