Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: azure provider support #219

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

feat: azure provider support #219

wants to merge 7 commits into from

Conversation

vprusso
Copy link
Contributor

@vprusso vprusso commented Feb 14, 2025

  • Adding functionality for Azure-supported devices via provider interface.

Note: Until we obtain appropriate credentials for testing, this will stay in a draft state.

@vprusso vprusso changed the title 209 azure support feat: azure provider support Feb 14, 2025
@vprusso vprusso requested a review from cosenal February 14, 2025 12:46
AZURE_SUBSCRIPTION_ID="<AZURE_SUBSCRIPTION_ID>"
AZURE_RESOURCE_GROUP="<AZURE_RESOURCE_GROUP>"
AZURE_WORKSPACE_NAME="<AZURE_WORKSPACE_NAME>"
AZURE_LOCATION="<AZURE_LOCATION>" # e.g. "westus"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we shall add the other three as well

AZURE_CLIENT_ID
AZURE_CLIENT_SECRET
AZURE_TENANT_ID

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in e578d2c

pyproject.toml Outdated
{ version = "0.2.12", markers = "sys_platform == 'darwin' and platform_machine == 'arm64'" },
{ version = "0.2.8", markers = "sys_platform == 'darwin' and platform_machine == 'x86_64'" }
]
pyquil = "^4.16.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pyquil should come from qbraid[azure], we don't need to add it explicitly

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in e578d2c

Copy link
Contributor

@cosenal cosenal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but as you say in the description, let's keep it as draft until it's tested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants