-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: azure provider support #219
base: main
Are you sure you want to change the base?
Conversation
AZURE_SUBSCRIPTION_ID="<AZURE_SUBSCRIPTION_ID>" | ||
AZURE_RESOURCE_GROUP="<AZURE_RESOURCE_GROUP>" | ||
AZURE_WORKSPACE_NAME="<AZURE_WORKSPACE_NAME>" | ||
AZURE_LOCATION="<AZURE_LOCATION>" # e.g. "westus" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we shall add the other three as well
AZURE_CLIENT_ID
AZURE_CLIENT_SECRET
AZURE_TENANT_ID
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done in e578d2c
pyproject.toml
Outdated
{ version = "0.2.12", markers = "sys_platform == 'darwin' and platform_machine == 'arm64'" }, | ||
{ version = "0.2.8", markers = "sys_platform == 'darwin' and platform_machine == 'x86_64'" } | ||
] | ||
pyquil = "^4.16.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pyquil should come from qbraid[azure]
, we don't need to add it explicitly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done in e578d2c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but as you say in the description, let's keep it as draft until it's tested.
Note: Until we obtain appropriate credentials for testing, this will stay in a draft state.