Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve dependency workflow #184

Merged
merged 1 commit into from
Jan 28, 2025
Merged

Improve dependency workflow #184

merged 1 commit into from
Jan 28, 2025

Conversation

cosenal
Copy link
Contributor

@cosenal cosenal commented Jan 28, 2025

Description

  • Remove dependencies that are no longer used in the project
  • ^ was checked with deptry, which is now a tool added to the project
  • new GitHub action to auto-merge dependabot PR for patch updates (who are we kidding, none of us goes through the changelog anyway before approving those PRs!)

Issue ticket number and link

Fixes #164

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules (or not applicable)

@cosenal cosenal added dependencies Pull requests that update a dependency file devops Operational project-based issue labels Jan 28, 2025
@cosenal cosenal requested a review from vprusso January 28, 2025 14:45
Copy link
Contributor

@vprusso vprusso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will save me from getting carpel tunnel syndrome in approving/merging all of the dependabot things each week. Nice!

@cosenal
Copy link
Contributor Author

cosenal commented Jan 28, 2025

@vprusso assuming that it works :)

@cosenal cosenal merged commit 45b5c4c into main Jan 28, 2025
2 checks passed
@cosenal cosenal deleted the dependency-cleaner-workflow branch January 28, 2025 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file devops Operational project-based issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants