feat(eth-lc): electra fork #3878
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
hussein-aitlahcen
force-pushed
the
ethereum-electra
branch
3 times, most recently
from
41de505 to
8be7bf4
Compare
hussein-aitlahcen
force-pushed
the
ethereum-electra
branch
from
8be7bf4 to
249756f
Compare
benluelo
reviewed
Feb 26, 2025
Comment on lines
+401
to
+407
| pub const FINALIZED_ROOT_GINDEX: u64 = 105; | ||
| /// `get_generalized_index(BeaconState, "current_sync_committee")` | ||
| pub const CURRENT_SYNC_COMMITTEE_INDEX: u64 = 54; | ||
| pub const CURRENT_SYNC_COMMITTEE_GINDEX: u64 = 54; | ||
| /// `get_generalized_index(BeaconState, "next_sync_committee")` | ||
| pub const NEXT_SYNC_COMMITTEE_INDEX: u64 = 55; | ||
| pub const NEXT_SYNC_COMMITTEE_GINDEX: u64 = 55; | ||
| /// `get_generalized_index(BeaconBlockBody, "execution_payload")` | ||
| pub const EXECUTION_PAYLOAD_INDEX: u64 = 25; | ||
| pub const EXECUTION_PAYLOAD_GINDEX: u64 = 25; |
There was a problem hiding this comment.
rename the old ones to deneb?
Comment on lines
+287
to
297
| // Now new field in electra | ||
| if epoch >= fork_parameters.electra.epoch { | ||
| return TryInto::<ExecutionPayloadHeaderSsz<C>>::try_into(header.execution.clone()) | ||
| .unwrap() | ||
| .tree_hash_root(); | ||
| } | ||
| if epoch >= fork_parameters.deneb.epoch { | ||
| return TryInto::<ExecutionPayloadHeaderSsz<C>>::try_into(header.execution.clone()) | ||
| .unwrap() | ||
| .tree_hash_root(); | ||
| } |
There was a problem hiding this comment.
these branches are the same?
Comment on lines
+46
to
+81
| // https://github.com/ethereum/consensus-specs/blob/dev/specs/altair/light-client/sync-protocol.md#finalized_root_gindex_at_slot | ||
| pub fn finalized_root_gindex_at_slot<C: ChainSpec>( | ||
| fork_parameters: &ForkParameters, | ||
| slot: Slot, | ||
| ) -> u64 { | ||
| let epoch = compute_epoch_at_slot::<C>(slot); | ||
| if epoch >= fork_parameters.electra.epoch { | ||
| return FINALIZED_ROOT_GINDEX_ELECTRA; | ||
| } | ||
| FINALIZED_ROOT_GINDEX | ||
| } | ||
|
|
||
| // https://github.com/ethereum/consensus-specs/blob/dev/specs/altair/light-client/sync-protocol.md#current_sync_committee_gindex_at_slot | ||
| pub fn current_sync_committee_gindex_at_slot<C: ChainSpec>( | ||
| fork_parameters: &ForkParameters, | ||
| slot: Slot, | ||
| ) -> u64 { | ||
| let epoch = compute_epoch_at_slot::<C>(slot); | ||
| if epoch >= fork_parameters.electra.epoch { | ||
| return CURRENT_SYNC_COMMITTEE_GINDEX_ELECTRA; | ||
| } | ||
| CURRENT_SYNC_COMMITTEE_GINDEX | ||
| } | ||
|
|
||
| // https://github.com/ethereum/consensus-specs/blob/dev/specs/altair/light-client/sync-protocol.md#next_sync_committee_gindex_at_slot | ||
| pub fn next_sync_committee_gindex_at_slot<C: ChainSpec>( | ||
| fork_parameters: &ForkParameters, | ||
| slot: Slot, | ||
| ) -> u64 { | ||
| let epoch = compute_epoch_at_slot::<C>(slot); | ||
| if epoch >= fork_parameters.electra.epoch { | ||
| return NEXT_SYNC_COMMITTEE_GINDEX_ELECTRA; | ||
| } | ||
| NEXT_SYNC_COMMITTEE_GINDEX | ||
| } | ||
|
|
There was a problem hiding this comment.
small nit but make the links doc comments: /// <link>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the new constants and refactor the existing LC to handle electra fork.
See https://github.com/ethereum/consensus-specs/blob/dev/specs/electra/light-client/sync-protocol.md