chore: more bn254 defaults

go.mod

@@ -3,7 +3,7 @@ go 1.23.1
 module github.com/cosmos/cosmos-sdk
 
 require (
-	buf.build/gen/go/cometbft/cometbft/protocolbuffers/go v1.34.2-20240701160653-fedbb9acfd2f.2
+	buf.build/gen/go/cometbft/cometbft/protocolbuffers/go v1.34.2-20240701160653-fedbb9acfd2f.2 // indirect
 	cosmossdk.io/api v0.8.0 // main
 	cosmossdk.io/collections v0.4.1-0.20240802064046-23fac2f1b8ab // main
 	cosmossdk.io/core v1.0.0-alpha.1

server/start.go

@@ -19,7 +19,7 @@ import (
 	cmtcmd "github.com/cometbft/cometbft/cmd/cometbft/commands"
 	cmtcfg "github.com/cometbft/cometbft/config"
 	cmtcrypto "github.com/cometbft/cometbft/crypto"
-	cmted25519 "github.com/cometbft/cometbft/crypto/ed25519"
+	"github.com/cometbft/cometbft/crypto/bn254"
 	cmtjson "github.com/cometbft/cometbft/libs/json"
 	"github.com/cometbft/cometbft/node"
 	"github.com/cometbft/cometbft/p2p"
@@ -375,7 +375,7 @@ func startCmtNode(
 	}
 
 	pv, err := pvm.LoadOrGenFilePV(cfg.PrivValidatorKeyFile(), cfg.PrivValidatorStateFile(), func() (cmtcrypto.PrivKey, error) {
-		return cmted25519.GenPrivKey(), nil
+		return bn254.GenPrivKey(), nil
 	}) // TODO:  make this modular
 	if err != nil {
 		return nil, cleanupFn, err
@@ -801,7 +801,7 @@ func testnetify[T types.Application](ctx *Context, testnetAppCreator types.AppCr
 	defer stateDB.Close()
 
 	privValidator, err := pvm.LoadOrGenFilePV(config.PrivValidatorKeyFile(), config.PrivValidatorStateFile(), func() (cmtcrypto.PrivKey, error) {
-		return cmted25519.GenPrivKey(), nil
+		return bn254.GenPrivKey(), nil
 	}) // TODO: make this modular
 	if err != nil {
 		return nil, err

server/v2/cometbft/server.go

@@ -12,6 +12,7 @@ import (
 	cmtcmd "github.com/cometbft/cometbft/cmd/cometbft/commands"
 	cmtcfg "github.com/cometbft/cometbft/config"
 	cmtcrypto "github.com/cometbft/cometbft/crypto"
+	cmtbn254 "github.com/cometbft/cometbft/crypto/bn254"
 	cmted25519 "github.com/cometbft/cometbft/crypto/ed25519"
 	"github.com/cometbft/cometbft/node"
 	"github.com/cometbft/cometbft/p2p"
@@ -153,7 +154,7 @@ func (s *CometBFTServer[T]) Start(ctx context.Context) error {
 		s.config.ConfigTomlConfig.PrivValidatorKeyFile(),
 		s.config.ConfigTomlConfig.PrivValidatorStateFile(),
 		func() (cmtcrypto.PrivKey, error) {
-			return cmted25519.GenPrivKey(), nil
+			return cmtbn254.GenPrivKey(), nil
 		},
 	)
 	if err != nil {

x/auth/ante/sigverify.go

@@ -17,6 +17,7 @@ import (
 	txsigning "cosmossdk.io/x/tx/signing"
 
 	codectypes "github.com/cosmos/cosmos-sdk/codec/types"
+	"github.com/cosmos/cosmos-sdk/crypto/keys/bn254"
 	"github.com/cosmos/cosmos-sdk/crypto/keys/ed25519"
 	kmultisig "github.com/cosmos/cosmos-sdk/crypto/keys/multisig"
 	"github.com/cosmos/cosmos-sdk/crypto/keys/secp256k1"
@@ -537,7 +538,6 @@ func DefaultSigVerificationGasConsumer(meter gas.Meter, sig signing.SignatureV2,
 		}
 
 		return nil
-
 	default:
 		return errorsmod.Wrapf(sdkerrors.ErrInvalidPubKey, "unrecognized public key type: %T", pubkey)
 	}

x/genutil/utils.go

@@ -100,7 +100,8 @@ func InitializeNodeValidatorFilesFromMnemonic(config *cfg.Config, mnemonic, keyT
 			privKey = cmtbn254.GenPrivKey()
 			filePV = loadOrGenFilePV(privKey, pvKeyFile, pvStateFile)
 		default:
-			filePV = loadOrGenFilePV(tmed25519.GenPrivKey(), pvKeyFile, pvStateFile)
+			privKey = cmtbn254.GenPrivKey()
+			filePV = loadOrGenFilePV(privKey, pvKeyFile, pvStateFile)
 		}
 	} else {
 		switch keyType {
@@ -112,7 +113,7 @@ func InitializeNodeValidatorFilesFromMnemonic(config *cfg.Config, mnemonic, keyT
 		case "bn254":
 			privKey = cmtbn254.GenPrivKeyFromSeed([]byte(mnemonic))
 		default:
-			privKey = tmed25519.GenPrivKeyFromSecret([]byte(mnemonic))
+			privKey = cmtbn254.GenPrivKeyFromSeed([]byte(mnemonic))
 		}
 		filePV = privval.NewFilePV(privKey, pvKeyFile, pvStateFile)
 		filePV.Save()