Refactor: Update CompactCount to use PluralCategory enum
#5401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
younies
requested review from
sffc,
robertbastian and
Manishearth
as code owners
robertbastian
previously approved these changes
Aug 20, 2024
robertbastian
approved these changes
Aug 20, 2024
| "few" => Count::Few, | ||
| "many" => Count::Many, | ||
| "other" => Count::Other, | ||
| "zero" => PluralCategory::Zero, |
There was a problem hiding this comment.
You can use PluralCategory::get_for_cldr_bytes here
| 3 => Count::Few, | ||
| 4 => Count::Many, | ||
| 5 => Count::Other, | ||
| 0 => PluralCategory::Zero, |
There was a problem hiding this comment.
You can use (unaligned.0 & 0b0000_0111) as PluralCategory, as it's repr(u8) with stable discriminants
There was a problem hiding this comment.
error[E0605]: non-primitive cast: `u8` as `PluralCategory`
--> components/experimental/src/dimension/provider/compact_count_ule.rs:67:22
|
67 | let count = (unaligned.0 & 0b0000_0111) as PluralCategory;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ an `as` expression can only be used to convert between primitive types or to coerce to a specific trait object
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to issue #5369.