Remove public export of ParseValue trait #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The documentation for its lone method indicated that it shouldn't be called externally - Its method was only callable if the trait was `use`d - The public `Parser` struct already provides the same functionality - Its lone method's interface exposed internal representation of the parser (`&mut Peekable<Chars>`), which may be changed in the future to accommodate things like copy-less parsing or configurations like RFC 9651
valenting
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
usedParserstruct already provides the same functionality&mut Peekable<Chars>), which may be changed in the future to accommodate things like copy-less parsing or configurations like RFC 9651