Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update format.yml #13479

Merged
merged 1 commit into from
Jan 1, 2025
Merged

Update format.yml #13479

merged 1 commit into from
Jan 1, 2025

Conversation

glenn-jocher
Copy link
Member

@glenn-jocher glenn-jocher commented Jan 1, 2025

πŸ› οΈ PR Summary

Made with ❀️ by Ultralytics Actions

🌟 Summary

Improved GitHub Actions workflow for formatting with enhanced token fallback logic. πŸ”§βœ¨

πŸ“Š Key Changes

  • Updated the .github/workflows/format.yml file to include a fallback mechanism for the token variable: ${{ secrets._GITHUB_TOKEN || secrets.GITHUB_TOKEN }}.

🎯 Purpose & Impact

  • Purpose: Ensures robust token access by adding an alternative option (secrets.GITHUB_TOKEN) if the primary token (secrets._GITHUB_TOKEN) is unavailable. πŸ› οΈ
  • Impact: Enhances workflow reliability and prevents potential issues with missing tokens during automated formatting tasks. βœ…

Signed-off-by: Glenn Jocher <[email protected]>
@UltralyticsAssistant UltralyticsAssistant added devops GitHub Devops or MLops enhancement New feature or request labels Jan 1, 2025
@UltralyticsAssistant
Copy link
Member

πŸ‘‹ Hello @glenn-jocher, thank you for submitting an ultralytics/yolov5 πŸš€ PR! To ensure a seamless integration of your work, please review the following checklist:

  • βœ… Define a Purpose: Clearly explain the purpose of your fix or feature in your PR description, and link to any relevant issues. Ensure your commit messages are clear, concise, and adhere to the project's conventions.
  • βœ… Synchronize with Source: Confirm your PR is synchronized with the ultralytics/yolov5 main branch. If it's behind, update it by clicking the 'Update branch' button or by running git pull and git merge main locally.
  • βœ… Ensure CI Checks Pass: Verify all Ultralytics Continuous Integration (CI) checks are passing. If any checks fail, please address the issues.
  • βœ… Update Documentation: Update the relevant documentation for any new or modified features.
  • βœ… Add Tests: If applicable, include or update tests to cover your changes, and confirm that all tests are passing.
  • βœ… Sign the CLA: Please ensure you have signed our Contributor License Agreement (CLA) if this is your first Ultralytics PR by writing "I have read the CLA Document and I sign the CLA" in a new message.
  • βœ… Minimize Changes: Limit your changes to the minimum necessary for your bug fix or feature addition. "It is not daily increase but daily decrease, hack away the unessential. The closer to the source, the less wastage there is." β€” Bruce Lee

For further guidance, please refer to our contributing guide or leave a comment if you have any questions. An Ultralytics engineer will review your PR and provide feedback soon. Thank you for your contribution! πŸš€

@glenn-jocher glenn-jocher merged commit 915ce21 into master Jan 1, 2025
8 checks passed
@glenn-jocher glenn-jocher deleted the glenn-jocher-patch-1 branch January 1, 2025 14:47
@UltralyticsAssistant
Copy link
Member

πŸš€ PR Merged! 🌟 Huge thanks, @glenn-jocher, for this impactful contribution to our GitHub Actions workflow! Your addition of robust fallback logic ensures a more resilient automation processβ€”keeping things running smoothly for everyone. πŸ’ͺ✨

As Marcus Aurelius once said, "What stands in the way becomes the way." Your solution embodies this spirit, transforming potential roadblocks into seamless paths forward. Thanks for helping us build tools that truly empower creators and collaborators worldwide! 🌍πŸ”₯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devops GitHub Devops or MLops enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants