Feature/gocart suv #113
Closed
Feature/gocart suv #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/CATChem into feature/gocart_suv
zmoon
reviewed
Jan 17, 2025
|
Yes!! Thanks!
…On Fri, Jan 17, 2025 at 1:11 PM Zachary Moon ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
On src/process/SUVolcanicEmissions/SUVolcanicEmissions_GOCART.F90
<#113 (comment)>
:
Should this file be removed?
—
Reply to this email directly, view it on GitHub
<#113 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BHNBJUZIDDKE5ECUFWHMRTT2LFBWDAVCNFSM6AAAAABVMJZB36VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDKNJZGY3TCMBZGE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
--
Lacey Holland, Ph.D.
Research Physical Scientist
Atmospheric Sciences Modeling Division (ASMD)
NOAA/OAR/ARL
NCWCP, Rm 4257
5830 University Research Court
College Park, Maryland 20740
(301) 427-7880
|
zmoon
reviewed
Jan 22, 2025
|
Yes!
Also, I made some required updates in the api directory. There are some
files that needed modified that I missed earlier!
…On Wed, Jan 22, 2025 at 5:49 PM Zachary Moon ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
On src/core/datetime.F90
<#113 (comment)>
:
This file seems to be unused, should it be removed?
—
Reply to this email directly, view it on GitHub
<#113 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BHNBJUZNEKEY5VSTXPSTVUT2MAN5VAVCNFSM6AAAAABVMJZB36VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDKNRYGQ2TENJXGU>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
--
Lacey Holland, Ph.D.
Research Physical Scientist
Atmospheric Sciences Modeling Division (ASMD)
NOAA/OAR/ARL
NCWCP, Rm 4257
5830 University Research Court
College Park, Maryland 20740
(301) 427-7880
|
Co-authored-by: lholland-noaa <[email protected]>
|
I resolved the merge conflict and got the linter passing here. If you have changes you haven't pushed, you'll have to merge this (the remote branch) into your local branch before you can push. |
zmoon
reviewed
Jan 23, 2025
|
Yes, it should. Thank, you!!
…On Thu, Jan 23, 2025 at 10:53 AM Zachary Moon ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In src/core/config_mod.F90
<#113 (comment)>
:
> +
+ ! Initialize
+ RC = CC_SUCCESS
+ thisLoc = ' -> at Config_Process_SUVolcanicEmissions (in CATChem/src/core/config_mod.F90)'
+ errMsg = ''
+
+ ! TODO #105 Fix reading of config file
+ key = "process%SUVolcanicEmissions%activate"
+ v_bool = MISSING_BOOL
+ CALL QFYAML_Add_Get( ConfigInput, TRIM( key ), v_bool, "", RC )
+ IF ( RC /= CC_SUCCESS ) THEN
+ errMsg = 'Error parsing ' // TRIM( key ) // '!'
+ CALL CC_Error( errMsg, RC, thisLoc )
+ RETURN
+ ENDIF
+ Config%drydep_activate = v_bool
Should be SUV instead?
—
Reply to this email directly, view it on GitHub
<#113 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BHNBJU7THX7SX2FWG7NP7632MEF73AVCNFSM6AAAAABVMJZB36VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDKNZQGI4DAMBQGM>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
--
Lacey Holland, Ph.D.
Research Physical Scientist
Atmospheric Sciences Modeling Division (ASMD)
NOAA/OAR/ARL
NCWCP, Rm 4257
5830 University Research Court
College Park, Maryland 20740
(301) 427-7880
|
zmoon
reviewed
Jan 24, 2025
|
Awesome, thanks!
…On Fri, Jan 24, 2025 at 10:21 AM Zachary Moon ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In tests/test_suvolcanic.F90
<#113 (comment)>
:
> + allocate(MetState%BXHEIGHT(MetState%NLEVS))
+ allocate(MetState%DELP(MetState%NLEVS))
+ MetState%NLEVS = 2
Looks like this would get the run succeeding
⬇️ Suggested change
- allocate(MetState%BXHEIGHT(MetState%NLEVS))
- allocate(MetState%DELP(MetState%NLEVS))
- MetState%NLEVS = 2
+ MetState%NLEVS = 2
+ allocate(MetState%BXHEIGHT(MetState%NLEVS))
+ allocate(MetState%DELP(MetState%NLEVS))
—
Reply to this email directly, view it on GitHub
<#113 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BHNBJUZMQFWN5IAYPRE5OOL2MJK7TAVCNFSM6AAAAABVMJZB36VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDKNZSHE2DGOJVGI>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
--
Lacey Holland, Ph.D.
Research Physical Scientist
Atmospheric Sciences Modeling Division (ASMD)
NOAA/OAR/ARL
NCWCP, Rm 4257
5830 University Research Court
College Park, Maryland 20740
(301) 427-7880
|
zmoon
reviewed
Feb 7, 2025
| @@ -0,0 +1,139 @@ | |||
| program test_suvolcanic | |||
| use CATChem, fp => cc_rk | |||
| use testing_mod, only: assert | |||
There was a problem hiding this comment.
Could you update the test to assert some things about the results?
|
Great catches. Thanks!
…On Friday, February 7, 2025, Zachary Moon ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In tests/test_suvolcanic.F90
<#113 (comment)>
:
> @@ -0,0 +1,139 @@
+program test_suvolcanic
+ use CATChem, fp => cc_rk
+ use testing_mod, only: assert
Could you update the test to assert some things about the results?
—
Reply to this email directly, view it on GitHub
<#113 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BHNBJUYL7RILCHYXZ2STAWD2OUZUNAVCNFSM6AAAAABVMJZB36VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDMMBTGAYDMNJTGY>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
--
Lacey Holland, Ph.D.
Research Physical Scientist
Atmospheric Sciences Modeling Division (ASMD)
NOAA/OAR/ARL
NCWCP, Rm 4257
5830 University Research Court
College Park, Maryland 20740
(301) 427-7880
|
Added "assert" command
Note on data that needs to go into SUVolcanicEmissionsState
|
Closing in favor of #117 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding interface w/ GOCART Sulfur Volcanic Emissions