Infer signature fix - no longer needed #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CC: @SudKul |
rayryeng
force-pushed
the
infer_signature_fix
branch
from
41249cf to
5659fdf
Compare
|
Can I have you look at this and merge it? This is the last piece of the puzzle that will allow for more seamless completion. This small piece is another issue that was very popular in the knowledge forums that I've had to continue resolving. With this, the amount of technical inquiries for completing this project should decrease. |
rayryeng
force-pushed
the
infer_signature_fix
branch
from
5659fdf to
900ab82
Compare
|
@rayryeng Thanks Ray for working on it. I've merged it. |
|
@islamalsawy thank you for your speedy review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the recent updates to the scikit-learn and scipy packages in this pull request (#22), the
infer_signaturemethod found insrc/train_random_forest/run.pyis no longer required and does not need to be used in themlflow.sklearn.save_modelmethod. Leaving this alone will generate the following error (provided by a student):As such, this PR removes the
infer_signaturecall to remove this error - it is no longer needed. This PR also updates one conda.yml file so that the scikit-learn version is set to 1.5.2, like all other conda.yml files in this repository. Finally, in thesrc/train_random_forest/run.pyfile, a hint refers to using theOneHotEncoderclass, but it is not imported as part of import statements. Questions were also asked in this regard, so to make things slightly easier, this import statement was completed to be preemptive.