Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PVG that downstream node skipped mistakenly after cleaving #826

Merged
merged 3 commits into from
Nov 14, 2023

Conversation

zhuchcn
Copy link
Member

@zhuchcn zhuchcn commented Nov 14, 2023

Description

This very tricky issue only appears when the 6 SNVs + indels are present together. Leaving anyone out will make the issue disappear.

Issue in graph digestion. When determining the downstream nodes for the next iteration after cleaving a bubble, the outbound node of a newly created node (by merging or cleaving) is usually skipped if the new node contains frameshifting variants. However, if the outbound node contains multiple inbound nodes, and all of them are created in the current bubble, it should still be processed and identified as a downstream node, otherwise, it will remain as uncleaved and result in potential invalid characters (e.g., *).

Closes #...

Checklist

  • This PR does NOT contain PHI or germline genetic data. A repo may need to be deleted if such data is uploaded. Disclosing PHI is a major problem.
  • This PR does NOT contain molecular files, compressed files, output files such as images (e.g. .png, .jpeg), .pdf, .RData, .xlsx, .doc, .ppt, or other non-plain-text files. To automatically exclude such files using a .gitignore file, see here for example.
  • I have read the code review guidelines and the code review best practice on GitHub check-list.
  • The name of the branch is meaningful and well formatted following the standards, using [AD_username (or 5 letters of AD if AD is too long)]-[brief_description_of_branch].
  • I have added the major changes included in this pull request to the CHANGELOG.md under the next release version or unreleased, and updated the date.
  • All test cases passed locally.

…tream node of a bridge out node with multiple inbond node should not be skipped if all of its inbond nodes are in the current bubble
@zhuchcn zhuchcn marked this pull request as ready for review November 14, 2023 07:23
@zhuchcn zhuchcn requested a review from lydiayliu November 14, 2023 07:23
@zhuchcn zhuchcn merged commit 0f2bd2f into main Nov 14, 2023
2 checks passed
@zhuchcn zhuchcn deleted the czhu-fix-call-variant branch November 14, 2023 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants