explicitly set label to node id

[whelena]

Description

Make sure label is set to node id when its missing from the tree dataframe

Checklist

• This PR does NOT contain Protected Health Information (PHI). A repo may need to be deleted if such data is uploaded.
  Disclosing PHI is a major problem¹ - Even a small leak can be costly².

• This PR does NOT contain germline genetic data³, RNA-Seq, DNA methylation, microbiome or other molecular data⁴.

• This PR does NOT contain other non-plain text files, such as: compressed files, images (e.g. .png, .jpeg), .pdf, .RData, .xlsx, .doc, .ppt, or other output files.

  To automatically exclude such files using a .gitignore file, see here for example.

• I have read the code review guidelines and the code review best practice on GitHub check-list.

• I have set up or verified the main branch protection rule following the github standards before opening this pull request.

• The name of the branch is meaningful and well formatted following the standards, using [AD_username (or 5 letters of AD if AD is too long)]-[brief_description_of_branch].

• I have added the major changes included in this pull request to the CHANGELOG.md under the next release version or unreleased, and updated the date.

Footnotes

1. UCLA Health reaches $7.5m settlement over 2015 breach of 4.5m patient records ↩

2. The average healthcare data breach costs $2.2 million, despite the majority of breaches releasing fewer than 500 records. ↩

3. Genetic information is considered PHI.
   Forensic assays can identify patients with as few as 21 SNPs ↩

4. RNA-Seq, DNA methylation, microbiome, or other molecular data can be used to predict genotypes (PHI) and reveal a patient's identity. ↩

[dan-knight]

Any reason why we don't want to just set the rownames for compatibility with SRCGrob?

[whelena]

Any reason why we don't want to set the rownames for compatibility with SRCGrob?

I'm setting rownames is set to node.id column if it is specified, which is compatible with SRCgron. Then, label can be different from node.id but if its not specified it should default to node.id.

Basically without the line I added, the label defaults to an ordered, numeric thing even if node.id is not numeric

[dan-knight]

Interesting. I remember this issue, but I'd have thought that SRCGrob would handle it automatically. If not, this makes sense.

[whelena]

Yea, it was able to make the tree with the right edge connections but somehow the labels are still in numerical order.