-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
create.violinplot
: add panel arguments like in create.scatterplot
#188
base: main
Are you sure you want to change the base?
Conversation
Sorry if I'm missing it, but where is |
Sorry for accidentally closing the PR. @dan-knight : I'm not sure, but this issue/PR is not related to |
Ah, it must've just showed up in the changes alongside your actual changes. Sorry about the confusion. |
@@ -25,7 +25,8 @@ create.violinplot <- function( | |||
xleft.rectangle = NULL, ybottom.rectangle = NULL, xright.rectangle = NULL, ytop.rectangle = NULL, | |||
col.rectangle = 'transparent', alpha.rectangle = 1, height = 6, width = 6, resolution = 1600, | |||
size.units = 'in', enable.warnings = FALSE, description = 'Created with BoutrosLab.plotting.general', | |||
style = 'BoutrosLab', preload.default = 'custom', use.legacy.settings = FALSE, disable.factor.sorting = FALSE | |||
style = 'BoutrosLab', preload.default = 'custom', use.legacy.settings = FALSE, disable.factor.sorting = FALSE, | |||
strip.col = 'white', strip.cex = 1, strip.fontface = 'bold', layout = NULL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dan-knight : the new parameters are strip.col, strip.cex, strip.fontface, layout
- all used in create.scatterplot
and create.boxplot
Description
Add panel arguments to
create.violinplot
that are also used increate.scatterplot, create.boxplot
. See Tests below for examples.Closes #186
Checklist
This PR does NOT contain PHI or germline genetic data. A repo may need to be deleted if such data is uploaded. Disclosing PHI is a major problem.
This PR does NOT contain molecular files, compressed files, output files such as images (e.g.
.png
, .jpeg
),.pdf
,.RData
,.xlsx
,.doc
,.ppt
, or other non-plain-text files. To automatically exclude such files using a .gitignore file, see here for example.I have read the code review guidelines and the code review best practice on GitHub check-list.
I have set up or verified the
main
branch protection rule following the github standards before opening this pull request.The name of the branch is meaningful and well formatted following the standards, using [AD_username (or 5 letters of AD if AD is too long)]-[brief_description_of_branch].
I have added the major changes included in this pull request to the
NEWS
under the next release version or unreleased, and updated the date. I have also updated the version number inDESCRIPTION
according to semantic versioning rules.Both
R CMD build
andR CMD check
run successfully.Testing Results
Created on 2024-08-09 with reprex v2.0.2