Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add gnuplot for plot-bamstats #22

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

add gnuplot for plot-bamstats #22

wants to merge 5 commits into from

Conversation

sorelfitzgibbon
Copy link
Contributor

Description

  • gnuplot is needed for plot-bamstats which can be used to generate QC plots from SAMtools stats output as proposed for pipeline-generate-SQC-BAM.

  • samtools image size went from 285MB to 318MB

  • I'm not sure how the version will be handled since the release number is tied to the SAMtools version.

Testing Results

Docker Image Testing

  • I have tested the Docker image with the docker run command as described below.
docker run --workdir $(pwd) --rm --user $(id -u):$(id -g) --volume $(pwd):$(pwd) \
     --volume /hot/ref/mitochondria_ref/mt_test_bams/:/hot/ref/mitochondria_ref/mt_test_bams/ \
    ghcr.io/uclahs-cds/samtools:branch-sfitz-add-gnu \
    samtools stats tcga_test_file_normal.bam > tcga_test_file_normal_stats.txt

docker run --workdir $(pwd) --rm --user $(id -u):$(id -g) --volume $(pwd):$(pwd) \
     --volume /hot/ref/mitochondria_ref/mt_test_bams/:/hot/ref/mitochondria_ref/mt_test_bams/ \
    ghcr.io/uclahs-cds/samtools:branch-sfitz-add-gnu \
    plot-bamstats -p tcga_test tcga_test_file_normal_stats.txt

This test yields a few Fontconfig error: No writable cache directories errors and "tcga_test-quals2.gp" line 626: warning: y2 axis range undefined or overflow, resetting to [0:0]. But the plots are created and look fine. The same errors were seen for the PCAWG test run linked above proposed for....

Checklist

Formatting

File Updates

  • I have ensured that the version number update follows the versioning standards.

  • I have updated the version number in the Dockerfile, README.md and metadata.yaml files.

  • I have updated the dependencies and added my name to the maintainer list in the Dockerfile.

  • I have updated the feature changes in the README.md (optional).

  • I have added the changes included in this pull request to the CHANGELOG.md under the next release version or unreleased, and updated the date.

GitHub Packages Auto Build Rules

  • I have not manually pushed this Docker image to the uclahs-cds container registry (ghcr.io/uclahs-cds) on GitHub.

  • I have updated the image_name in the metadata.yaml which is required by GitHub action to automatically build and push the image.

@wiz-inc-8da00b022c
Copy link

wiz-inc-8da00b022c bot commented Jan 15, 2025

Wiz Scan Summary

Scanner Findings
Vulnerability Finding Vulnerabilities
Data Finding Sensitive Data
Secret Finding Secrets
IaC Misconfiguration IaC Misconfigurations 1 Medium
Total 1 Medium

View scan details in Wiz

To detect these findings earlier in the dev lifecycle, try using Wiz Code VS Code Extension.

@yashpatel6
Copy link
Contributor

For the release, we can essentially re-tag the SAMtools version since I don't think we're pinning a specific version of gnuplot in the Docker

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants