Execute jobs #278

jaypark25 · 2025-02-07T21:30:39Z

Proposed Changes

resolves #231 , #220
modifies #219

armintalaie

@jaypark25 this looks really good. Very impressed. I'd like you to make some changes/remove files and ping me again. I'd like to test locally as well before i merge.

armintalaie · 2025-02-07T21:32:59Z

backend/README.md

@@ -107,7 +112,7 @@ We use SqlAlchemy and Alembic for database migrations. The database is hosted on
 2. Run the following command to generate a new migration:

 ```bash
-uv run --env-file .env alembic revision --autogenerate -m "migration message"
+d


armintalaie · 2025-02-07T21:34:16Z

backend/.gitignore

+node_modules/
+


should not be needed to be added. if u have node_modules in your backend folder, you might have accidentally ran yarn install in it; you can delete node_modules in the backend if you have one in your local

armintalaie · 2025-02-07T21:36:42Z

backend/uv.lock

Btw for easy deployment - CD does not use UV and it attempts to install deps from requirements.txt - we use UV and to help deployment to be aware of the new package, run uv pip freeze > requirements.txt (i think that is the right command)
then commit and push the added .txt file

armintalaie · 2025-02-07T21:37:17Z

backend/package.json

delete file? package.json is for Node.js

armintalaie · 2025-02-07T21:37:32Z

backend/package-lock.json

delete file? package-lock.json is for Node.js

armintalaie · 2025-02-07T21:38:30Z

backend/main.py

@@ -13,6 +13,7 @@
 from routers.routes.query_history import query_history_router
 from routers.routes.users import user_router
 from routers.routes.invites import invite_router
+from core.scheduler import init_scheduler


does this file need this import?

armintalaie · 2025-02-07T21:51:35Z

backend/core/jobs/print_hi.py

@@ -0,0 +1,30 @@
+from pydantic import BaseModel
+
+class Print_HiParams(BaseModel):


is the naming convention here <camelcase filename>Params?

yes -- should we change?

im changing pascal

armintalaie

Thanks for the edits. im merging it. since it's not used internally yet. on Sat we can try adding a "embed" job with shreyas on post creation cc @xenshreyas

* feat: implement job scheduler and execution system with runnable * deleted test file * cleaned up code from PR, added a sample job for dev guidelining

Create blank issue template (#246) Create blank issue tempalte Cleanup Migration (#238) * lots of cleanup on db side * attempt: fixed dup fkey genereation * ignoring pylance issues for old migration issues * formatting * vs code exclude ruff cache * merge heads 129 create privacy policy and terms of service (#248) * Add terms and privacy pages * Remove unneeded exports * fix lint * Fix errors in text and change wording * Create SECURITY.md (#243) * Create blank issue template (#246) Create blank issue tempalte * Create bug reporting issue template (#244) * Update issue templates * Update bug-report.md * Reimplement privacy and terms using MDX components * moved mdx types to dev deps --------- Co-authored-by: Arman Moztarzadeh <[email protected]> Co-authored-by: Armin Talaie <[email protected]> Remove duplicated blank issue template (#250) remove duplicated blank issue template desktop app setup with Tauri (#252) Tags API and migrations (#237) * migrations for roles and tags * migration works just update head * minor db model changes for semantics and due to errors * roles init commit * implemented several more apis * updated migrations to remove roles, commented out roles db and created new migration for only tags * init first get tag for roles * imports * comment out role code * commit to fix migration head * added post_tag and doc_tags tables * place migrations on top of new head * updated foreign key for post ID from INT to UUID (to match the changed type from merge) * added back queryhistory model * brought back get_all_tags from merge * comment out more courserole stuff * create tag endpoint * added general crud for tags * renamed tags specific to courses, course tags * added post_tags * fixed all errors with migration * minor refactor for post tags * added document tagging * lots of cleanup on db side * attempt: fixed dup fkey genereation * ignoring pylance issues for old migration issues * formatting * vs code exclude ruff cache * updated to grab authenticated user for created_by field * removed commented out roles * updated migrations, removed more role stuff * clean up + include pydantic schema * removed role imports * remove optional for course_id * updated migration head after pulling cleanup * kept enum model and fixed small insert error with post tag + doc tag * merge migrations from dev * merge heads for db * formatting * fixed type issues --------- Co-authored-by: harshamin <[email protected]> Co-authored-by: Armin Talaie <[email protected]> Co-authored-by: Arman Moztarzadeh <[email protected]> Update issue templates (#247) * Update issue templates * Update feature_request.md * Update feature_request.md Setting Theme Refresh (#258) * added revalidate route for cache, used when theme gets updated ya feel * real time setting updating, so real, fr fr * yarn format and lint Landing Page Initialization [V1] (#259) * init landing page * fix styling for mobile * switch to light theme Include type field for issue templates (#261) * Add type field to issue templates * Update feature issue tempalte * small change * Include related issues for feature re-order items in header fix fix button styling Updated Settings Page (#276) * better routing * formatting * migrated settings mgmt state to zustand + enhanced settings page * replaced coursecontext with coursestore * theme tuning User management (#275) * user management * new files * updated migrations --------- Co-authored-by: Arman Moztarzadeh <[email protected]> Execute jobs (#278) * feat: implement job scheduler and execution system with runnable * deleted test file * cleaned up code from PR, added a sample job for dev guidelining

* feat: implement job scheduler and execution system with runnable * deleted test file * cleaned up code from PR, added a sample job for dev guidelining

* Add basic websocket implementation * revert migration file * Fix merge conflicts * Add temporary frontend files * add basic websocket implementation * Reset migrations and add template code for chat * Fix overlap by adding spacing and changing font size (#245) * Fix overlap by adding spacing and changing font size * fix lint * Create SECURITY.md (#243) * Create blank issue template (#246) Create blank issue tempalte * Create bug reporting issue template (#244) * Update issue templates * Update bug-report.md * Cleanup Migration (#238) * lots of cleanup on db side * attempt: fixed dup fkey genereation * ignoring pylance issues for old migration issues * formatting * vs code exclude ruff cache * merge heads * 129 create privacy policy and terms of service (#248) * Add terms and privacy pages * Remove unneeded exports * fix lint * Fix errors in text and change wording * Create SECURITY.md (#243) * Create blank issue template (#246) Create blank issue tempalte * Create bug reporting issue template (#244) * Update issue templates * Update bug-report.md * Reimplement privacy and terms using MDX components * moved mdx types to dev deps --------- Co-authored-by: Arman Moztarzadeh <[email protected]> Co-authored-by: Armin Talaie <[email protected]> * Remove duplicated blank issue template (#250) remove duplicated blank issue template * Create blank issue template (#246) Create blank issue tempalte * Cleanup Migration (#238) * lots of cleanup on db side * attempt: fixed dup fkey genereation * ignoring pylance issues for old migration issues * formatting * vs code exclude ruff cache * merge heads * 129 create privacy policy and terms of service (#248) * Add terms and privacy pages * Remove unneeded exports * fix lint * Fix errors in text and change wording * Create SECURITY.md (#243) * Create blank issue template (#246) Create blank issue tempalte * Create bug reporting issue template (#244) * Update issue templates * Update bug-report.md * Reimplement privacy and terms using MDX components * moved mdx types to dev deps --------- Co-authored-by: Arman Moztarzadeh <[email protected]> Co-authored-by: Armin Talaie <[email protected]> * Remove duplicated blank issue template (#250) remove duplicated blank issue template * Implement functional chat room * Add token verification * Remove supabase channel listening and use websockets to broadcast * Rename files and change naming conventions * Create blank issue template (#246) Create blank issue tempalte * Cleanup Migration (#238) * lots of cleanup on db side * attempt: fixed dup fkey genereation * ignoring pylance issues for old migration issues * formatting * vs code exclude ruff cache * merge heads * 129 create privacy policy and terms of service (#248) * Add terms and privacy pages * Remove unneeded exports * fix lint * Fix errors in text and change wording * Create SECURITY.md (#243) * Create blank issue template (#246) Create blank issue tempalte * Create bug reporting issue template (#244) * Update issue templates * Update bug-report.md * Reimplement privacy and terms using MDX components * moved mdx types to dev deps --------- Co-authored-by: Arman Moztarzadeh <[email protected]> Co-authored-by: Armin Talaie <[email protected]> * Remove duplicated blank issue template (#250) remove duplicated blank issue template * desktop app setup with Tauri (#252) * Tags API and migrations (#237) * migrations for roles and tags * migration works just update head * minor db model changes for semantics and due to errors * roles init commit * implemented several more apis * updated migrations to remove roles, commented out roles db and created new migration for only tags * init first get tag for roles * imports * comment out role code * commit to fix migration head * added post_tag and doc_tags tables * place migrations on top of new head * updated foreign key for post ID from INT to UUID (to match the changed type from merge) * added back queryhistory model * brought back get_all_tags from merge * comment out more courserole stuff * create tag endpoint * added general crud for tags * renamed tags specific to courses, course tags * added post_tags * fixed all errors with migration * minor refactor for post tags * added document tagging * lots of cleanup on db side * attempt: fixed dup fkey genereation * ignoring pylance issues for old migration issues * formatting * vs code exclude ruff cache * updated to grab authenticated user for created_by field * removed commented out roles * updated migrations, removed more role stuff * clean up + include pydantic schema * removed role imports * remove optional for course_id * updated migration head after pulling cleanup * kept enum model and fixed small insert error with post tag + doc tag * merge migrations from dev * merge heads for db * formatting * fixed type issues --------- Co-authored-by: harshamin <[email protected]> Co-authored-by: Armin Talaie <[email protected]> Co-authored-by: Arman Moztarzadeh <[email protected]> * Update issue templates (#247) * Update issue templates * Update feature_request.md * Update feature_request.md * Setting Theme Refresh (#258) * added revalidate route for cache, used when theme gets updated ya feel * real time setting updating, so real, fr fr * yarn format and lint * Landing Page Initialization [V1] (#259) * init landing page * fix styling for mobile * switch to light theme * Include type field for issue templates (#261) * Add type field to issue templates * Update feature issue tempalte * small change * Include related issues for feature * re-order items in header * fix * fix button styling * Updated Settings Page (#276) * better routing * formatting * migrated settings mgmt state to zustand + enhanced settings page * replaced coursecontext with coursestore * theme tuning * User management (#275) * user management * new files * updated migrations --------- Co-authored-by: Arman Moztarzadeh <[email protected]> * Execute jobs (#278) * feat: implement job scheduler and execution system with runnable * deleted test file * cleaned up code from PR, added a sample job for dev guidelining * Fix lint issues and use prettier --------- Co-authored-by: Arman Moztarzadeh <[email protected]> Co-authored-by: Armin Talaie <[email protected]> Co-authored-by: Caeleb Koharjo <[email protected]> Co-authored-by: harshamin <[email protected]> Co-authored-by: Diego Ayoubzadeh <[email protected]> Co-authored-by: Shreyas Goyal <[email protected]> Co-authored-by: Shreyas Goyal <[email protected]> Co-authored-by: malcolmm20 <[email protected]> Co-authored-by: Kangbin (Jay) Park <[email protected]>

jaypark25 added 2 commits February 7, 2025 13:27

feat: implement job scheduler and execution system with runnable

8206966

deleted test file

bb1fbec

jaypark25 requested a review from armintalaie as a code owner February 7, 2025 21:30

jaypark25 requested review from rayzhou4 and armintalaie and removed request for armintalaie February 7, 2025 21:30

armintalaie requested changes Feb 7, 2025

View reviewed changes

armanmoztar assigned jaypark25 Feb 7, 2025

armanmoztar added the backend label Feb 7, 2025

cleaned up code from PR, added a sample job for dev guidelining

0d1664e

armintalaie approved these changes Feb 7, 2025

View reviewed changes

armintalaie merged commit cbc0845 into dev Feb 7, 2025
5 checks passed

armintalaie deleted the execute-jobs branch February 7, 2025 23:50

bcw117 pushed a commit that referenced this pull request Feb 8, 2025

Execute jobs (#278)

0115b13

* feat: implement job scheduler and execution system with runnable * deleted test file * cleaned up code from PR, added a sample job for dev guidelining

bcw117 pushed a commit that referenced this pull request Feb 8, 2025

Execute jobs (#278)

b6a5630

* feat: implement job scheduler and execution system with runnable * deleted test file * cleaned up code from PR, added a sample job for dev guidelining

bcw117 pushed a commit that referenced this pull request Feb 8, 2025

Execute jobs (#278)

9962ba4

* feat: implement job scheduler and execution system with runnable * deleted test file * cleaned up code from PR, added a sample job for dev guidelining

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Execute jobs #278

Execute jobs #278

jaypark25 commented Feb 7, 2025 •

edited by armintalaie

Loading

armintalaie left a comment •

edited

Loading

armintalaie Feb 7, 2025

armintalaie Feb 7, 2025

armintalaie Feb 7, 2025

armintalaie Feb 7, 2025

armintalaie Feb 7, 2025

armintalaie Feb 7, 2025

armintalaie Feb 7, 2025

jaypark25 Feb 7, 2025

jaypark25 Feb 7, 2025

armintalaie left a comment

		@@ -0,0 +1,30 @@
		from pydantic import BaseModel

		class Print_HiParams(BaseModel):

		node_modules/

Execute jobs #278

Execute jobs #278

Conversation

jaypark25 commented Feb 7, 2025 • edited by armintalaie Loading

Proposed Changes

armintalaie left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

armintalaie left a comment

Choose a reason for hiding this comment

jaypark25 commented Feb 7, 2025 •

edited by armintalaie

Loading

armintalaie left a comment •

edited

Loading