XDMoD 11.0 PHP 8.1 Changes #1862
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- acl-config
- `join` function signature has changed in PHP8
- RealmManager.php
- The order in which these values were being returned differed between PHP7.2
and PHP8.0. I've just added code to force the ordering to be as we expect.
- ExportBuilder.php
- PHP8 is more strict in what it allows in function signatures and optional
arguments (arguments with default values) cannot come before required
arguments (arguments without default values).
- Visualization.php
- HSVtoRGB: PHP7.2 did more coercing of types than PHP8 does so we needed an
explicit cast to int here.
- pdoAggregator.php
- The previous code here expected that `current` would always return an
`array` when it can also return a `bool`. I've just updated the code to take
this into account.
- HpcdbHostsIngestor.php
- updated the function signature of `transform` so that it matches it's parent
`pdoIngestor`
- aRdbmsDestinationAction.php
- This code previously assumed that `$item['alias']` was going to be an array
and that it would contain a key 'as'. I just made it explicit.
- composer.json
- Added PHP8.0 to the list of supported PHP's.
- Updated phpoffice/phpword's version to * because the previous version
doesn't support PHP8
- Updated PHPUnit to 9+ as it was the most recent version that supported
PHP8.0
PHPUnit9+ changes
The "types" of changes in this commit are all related to PHPUnit9+ and PHP8:
- PHP8 reports a larger mantissa than in PHP7.2 so a few values have been
updated to reflect that.
- PHPUnit9+ uses actual namespacing so anywhere there was
`PHPUnit_Framework_TestCase` has been changed to
`\PHPUnit\Framework\TestCase`. The same basic idea was applied to Errors and
Exceptions as well.
- PHPUnit9+ has added some new functions, deprecated others, and removed yet
others. There are numerous locations where substitutions for curently
recommended functions were made.
- phpunit.xml.dist files have been updated
Documentation Changes
- The upgrade documentation has been upgraded to reflect the update of PHP to
8.0. Upgrade scenarios include:
- XDMoD 10.0 on EL7 w/ PHP 5.4
- XDMoD 10.5 on EL7 w/ PHP 7.2
- XDMoD 10.5 on EL8 w/ PHP 7.2
Co-authored-by: Joe White <[email protected]>
In the interest of keeping things the same I'm adding the composer dep that will provide the PHPUnit `assertArraySubset` functionality that we were using prior to it being removed.
This has been moved to `build.json`
These changes are to address deprecation notices generated by running the unit tests.
So this test currently errors out because the functions that are being mocked have a return type of `void` so it doesn't make sense to say they will return `null`.
I'd like to see if the UI tests pass.
ryanrath
force-pushed
the
xdmod11-php8-bkup
branch
from
71e5e76 to
c2ab373
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
Tests performed
Checklist: