chore:2733 design level refactoring #2736
Conversation
snehit221
changed the title
There was a problem hiding this comment.
Is this the same refactor as #2734 ?
| @Override | ||
| public int hashCode() { | ||
| int h = hash; | ||
| if (h == 0) { | ||
| h = internalHashCode(); | ||
| hash = h; | ||
| } | ||
| return h; | ||
| } | ||
|
|
||
| protected int internalHashCode() { | ||
| final int prime = 31; | ||
| int result = 1; | ||
| result = | ||
| prime * result | ||
| + ((this.getPortletWindowId() == null) | ||
| ? 0 | ||
| : this.getPortletWindowId().hashCode()); | ||
| result = | ||
| prime * result | ||
| + ((this.getEventType() == null) ? 0 : this.getEventType().hashCode()); | ||
| return result; | ||
| } | ||
|
|
||
| @Override | ||
| public String toString() { | ||
| return this.getClass().getSimpleName() | ||
| + " [" | ||
| + "portletWindowId=" | ||
| + this.getPortletWindowId() | ||
| + "]"; |
There was a problem hiding this comment.
Would it make sense to leverage lombok for these?
https://projectlombok.org/features/EqualsAndHashCode
https://projectlombok.org/features/ToString
There was a problem hiding this comment.
Thanks @ChristianMurphy for sharing the link.
My primary goal was to find code duplicates like this and refactor them.
Since this code was duplicated in 5/6 classes, I have pulled up this method and variable to promote code re-use.
Meanwhile, If my refactor change is fine, May I request it to be merged ?
I will explore this and update this part in a separate PR subsequently.
ref PR: #2738
There was a problem hiding this comment.
is this the same as #2734 ?
Checklist