Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

derive Hash trait for Pdf #28

Merged
merged 3 commits into from
Nov 1, 2023
Merged

derive Hash trait for Pdf #28

merged 3 commits into from
Nov 1, 2023

Conversation

cmoog
Copy link
Contributor

@cmoog cmoog commented Nov 1, 2023

@cmoog cmoog mentioned this pull request Nov 1, 2023
Merged
@laurmaedje
Copy link
Member

I think I would prefer having an as_bytes(&self) -> &[u8] method on Chunk which just returns the bytes written so far.

@laurmaedje laurmaedje merged commit 126ff13 into typst:main Nov 1, 2023
1 check passed
@laurmaedje
Copy link
Member

Thanks! I'll make a new release shortly.

laurmaedje pushed a commit that referenced this pull request Nov 1, 2023
@cmoog @laurmaedje
Add Chunk::as_bytes (#28)
faf420e
@cmoog cmoog deleted the hash branch November 1, 2023 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cmoog @laurmaedje