Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lasaveur:0.1.4 and touying2video:0.1.0 #2092

Merged
merged 4 commits into from
Apr 1, 2025
Merged

Conversation

yangwenbo99
Copy link
Contributor

@yangwenbo99 yangwenbo99 commented Mar 29, 2025

I am submitting

  • a new package
  • an update for a package

Description:

  • Adding a new package touying2video. The Typst package integrates with my external tool yangwenbo99/touying2video to generate a video (with AI voice over) from touying slides.
  • Updating lasaveur, replacing sect with inter to suppress warnings.

I have read and followed the submission guidelines and, in particular, I

  • selected a name that isn't the most obvious or canonical name for what the package does
  • added a typst.toml file with all required keys
  • added a README.md with documentation for my package
  • have chosen a license and added a LICENSE file or linked one in my README.md
  • tested my package locally on my system and it worked
  • excluded PDFs or README images, if any, but not the LICENSE

@typst-package-check typst-package-check bot changed the title touying2video:0.1.0 and lasaveur:0.1.4 lasaveur:0.1.4 and touying2video:0.1.0 Mar 29, 2025
@typst-package-check typst-package-check bot added new A new package submission. update A package update. labels Mar 29, 2025
@elegaanz
Copy link
Member

Regarding the CI warnings, I understand that they are false positives in lasaveur, but it would be nice if you could use kebab-case names for touying2video, to be more consistent with the standard library and most other packages. If you have a strong preference for snake_case, it is also possible to keep it as is, so let me know what you prefer.

Also, mandatory ping about the use of "touying" in another package name @OrangeX4 (the name is creative according from my side).

@OrangeX4
Copy link
Contributor

I think these names are all okay :-)

@yangwenbo99
Copy link
Contributor Author

Thanks for the reminder. I have modified the arguments' names to kebab-case.

@elegaanz
Copy link
Member

elegaanz commented Apr 1, 2025

Thank you!

@elegaanz elegaanz merged commit a79c951 into typst:main Apr 1, 2025
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new A new package submission. update A package update.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants