Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

derive-it:0.1.3 #2090

Merged
merged 1 commit into from
Apr 1, 2025
Merged

derive-it:0.1.3 #2090

merged 1 commit into from
Apr 1, 2025

Conversation

0rphee
Copy link
Contributor

@0rphee 0rphee commented Mar 28, 2025

I am submitting

  • a new package
  • an update for a package

Changes:

@typst-package-check typst-package-check bot added the update A package update. label Mar 28, 2025
Copy link
Member

@elegaanz elegaanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small remark. It would also be nice if you could fix the warning about kebab-case reported in CI. After that it should be good to merge.

@0rphee
Copy link
Contributor Author

0rphee commented Mar 31, 2025

I've removed the example.pdf file, and the kebab-case is also fixed. As for the other warning regarding the relative import, I don't really know how to silence it... I've seen some other packages with example.typ's and some use the relative import and others the package specification (though I think for this case the relative path is more appropriate).

@elegaanz
Copy link
Member

elegaanz commented Apr 1, 2025

Yes, I tend to allow for this warning to be ignored because I understand it is inconvenient for package developers to have to switch between the two import syntaxes all the time, even if it is better to use the package specification since it lets users copy example files and paste them in their own projects directly. So don't worry too much about it. Thank you for fixing the other warnings, they were the most important.

@elegaanz elegaanz merged commit 2ef6539 into typst:main Apr 1, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
update A package update.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants