Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add java.net.ConnectException to the list of errors that force h… #65

Closed

Conversation

asorian0
Copy link

@asorian0 asorian0 commented Sep 16, 2024

…andling the error in the client so if during the usage of a node, the client would mark it as unhealthy if it just is not reachable.
Fix for #64

Change Summary

Added java.net.ConnectException to the list of errors that force handling the erorr in the client

PR Checklist

…andling the error in the client so if during the usage of a node, the client would mark it as unhealthy if it just is not reachable.
@tharropoulos
Copy link
Contributor

Thanks for the quick PR!
You can check out a relevant PR on #66, that addressed all java.net exceptions that might be thrown, just to be safe.

@asorian0
Copy link
Author

YW!! Even better though. Actually i was going to update the PR cause we got some java.net.SocketException due to changes in our infra. Hope your changes gets released soon.

Going to close this one

@asorian0 asorian0 closed this Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants