Merge pull request #731 from typed-ember/split-typechecking-from-tests

Split typechecking from tests
typed-ember · Jun 21, 2024 · fcc2294 · fcc2294
2 parents 2e45a79 + f9da4e0
commit fcc2294
Show file tree

Hide file tree

Showing 127 changed files with 1,847 additions and 801 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -19,29 +19,45 @@ env:
   CI: true
 
 jobs:
+  lint: 
+    name: Lint
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+      - uses: actions/setup-node@v4
+        with:
+          node-version: 18
+          cache: yarn
+
+      - run: yarn install --frozen-lockfile
+      - run: yarn lint
+
+
+  type-tests:
+    name: "Type Tests"
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+      - uses: actions/setup-node@v4
+        with:
+          node-version: 18
+          cache: yarn
+
+      - run: yarn install --frozen-lockfile
+      - run: "yarn build"
+      - run: "yarn workspaces run test:typecheck"
+      - run: "yarn workspaces run test:tsc"
+
   test:
     name: Test
     runs-on: ubuntu-latest
     steps:
-      - name: Checkout Code
-        uses: actions/checkout@v3
-      - name: Install Node
-        uses: actions/setup-node@v3
+      - uses: actions/checkout@v4
+      - uses: actions/setup-node@v4
         with:
           node-version: 18
-      - name: Locate Yarn Cache
-        id: yarn-cache-dir-path
-        run: echo "dir=$(yarn cache dir)" >> $GITHUB_OUTPUT
-      - uses: actions/cache@v3
-        with:
-          path: ${{ steps.yarn-cache-dir-path.outputs.dir }}
-          key: ${{ runner.os }}-yarn-${{ hashFiles('**/yarn.lock') }}
-          restore-keys: |
-            ${{ runner.os }}-yarn-
-      - name: Install Dependencies
-        run: yarn install --frozen-lockfile
-      # - name: Lint
-      #   run: yarn lint
+          cache: yarn
+      - run: yarn install --frozen-lockfile
       - name: Build
         run: yarn build
       - name: Run Tests
@@ -88,14 +104,12 @@ jobs:
     name: Test Floating Dependencies
     runs-on: ubuntu-latest
     steps:
-      - name: Checkout Code
-        uses: actions/checkout@v3
-      - name: Install Node
-        uses: actions/setup-node@v3
+      - uses: actions/checkout@v4
+      - uses: actions/setup-node@v4
         with:
           node-version: 18
-      - name: Install Dependencies
-        run: yarn install --no-lockfile
+          cache: yarn
+      - run: yarn install --no-lockfile
       - name: Build
         run: yarn build
       - name: Run Tests
@@ -107,23 +121,13 @@ jobs:
     name: Test TypeScript Nightly
     runs-on: ubuntu-latest
     steps:
-      - name: Checkout Code
-        uses: actions/checkout@v3
-      - name: Install Node
-        uses: actions/setup-node@v3
+      - uses: actions/checkout@v4
+      - uses: actions/setup-node@v4
         with:
           node-version: 18
-      - name: Locate Yarn Cache
-        id: yarn-cache-dir-path
-        run: echo "dir=$(yarn cache dir)" >> $GITHUB_OUTPUT
-      - uses: actions/cache@v3
-        with:
-          path: ${{ steps.yarn-cache-dir-path.outputs.dir }}
-          key: ${{ runner.os }}-yarn-${{ hashFiles('**/yarn.lock') }}
-          restore-keys: |
-            ${{ runner.os }}-yarn-
-      - name: Install Dependencies
-        run: yarn add --dev -W typescript@next
+          cache: yarn
+      - run: yarn install --frozen-lockfile
+      - run: yarn add --dev -W typescript@next
       - name: Build
         run: yarn build
       - name: Run Tests

diff --git a/package.json b/package.json
@@ -9,9 +9,10 @@
   "scripts": {
     "lint": "yarn lint:scripts && yarn lint:formatting",
     "lint:fix": "yarn lint:scripts --fix && yarn prettier --write .",
-    "lint:scripts": "yarn eslint --max-warnings 0 --cache .",
+    "lint:scripts": "yarn eslint .",
     "lint:formatting": "yarn prettier --check .",
     "test": "yarn workspaces run test",
+    "test:typecheck": "yarn workspaces run test:typecheck",
     "build": "tsc --build",
     "release-it": "echo \"Running release-it via yarn breaks publishing! Use npx or a Volta global installation.\""
   },
@@ -30,7 +31,7 @@
     "@typescript-eslint/eslint-plugin": "^5.42.1",
     "@typescript-eslint/parser": "^5.42.1",
     "eslint": "^8.27.0",
-    "prettier": "^2.1.1",
+    "prettier": "^3.3.2",
     "release-it": "^15.5.0",
     "typescript": "~5.3.0"
   },

diff --git a/packages/core/__tests__/cli/build-watch.test.ts b/packages/core/__tests__/cli/build-watch.test.ts
@@ -115,7 +115,7 @@ describe.skip('CLI: watched build mode typechecking', () => {
       let stripped = stripAnsi(output);
       let error = stripped.slice(
         stripped.indexOf('index.gts'),
-        stripped.lastIndexOf(`~~~${os.EOL}`) + 3
+        stripped.lastIndexOf(`~~~${os.EOL}`) + 3,
       );
 
       expect(output).toMatch('Found 1 error.');
@@ -154,7 +154,7 @@ describe.skip('CLI: watched build mode typechecking', () => {
       let stripped = stripAnsi(output);
       let error = stripped.slice(
         stripped.indexOf('index.gts'),
-        stripped.lastIndexOf(`~~~${os.EOL}`) + 3
+        stripped.lastIndexOf(`~~~${os.EOL}`) + 3,
       );
 
       expect(output).toMatch('Found 1 error.');
@@ -349,14 +349,14 @@ describe.skip('CLI: watched build mode typechecking', () => {
 
           projects.main.write(
             INPUT_SFC,
-            mainCode.replace('{{this.startupTime}}', '{{this.startupTime}')
+            mainCode.replace('{{this.startupTime}}', '{{this.startupTime}'),
           );
 
           output = await watch.awaitOutput('Parse error');
           let stripped = stripAnsi(output);
           let error = stripped.slice(
             stripped.indexOf('index.gts'),
-            stripped.lastIndexOf(`~~~${os.EOL}`) + 3
+            stripped.lastIndexOf(`~~~${os.EOL}`) + 3,
           );
           expect(error).toMatchInlineSnapshot(`
             "index.gts:14:32 - error TS0: Parse error on line 3:
@@ -392,7 +392,7 @@ describe.skip('CLI: watched build mode typechecking', () => {
           let stripped = stripAnsi(output);
           let error = stripped.slice(
             stripped.indexOf('index.gts'),
-            stripped.lastIndexOf(`;${os.EOL}`) + 1
+            stripped.lastIndexOf(`;${os.EOL}`) + 1,
           );
           expect(error).toMatchInlineSnapshot(`
             "index.gts:3:28 - error TS0: Unclosed element \`C\`: 
@@ -430,7 +430,7 @@ describe.skip('CLI: watched build mode typechecking', () => {
           let stripped = stripAnsi(output);
           let error = stripped.slice(
             stripped.indexOf('index.gts'),
-            stripped.lastIndexOf(`~~~${os.EOL}`) + 3
+            stripped.lastIndexOf(`~~~${os.EOL}`) + 3,
           );
           expect(error).toMatchInlineSnapshot(`
             "index.gts:3:31 - error TS0: Parse error on line 1:
@@ -468,7 +468,7 @@ describe.skip('CLI: watched build mode typechecking', () => {
           let stripped = stripAnsi(output);
           let error = stripped.slice(
             stripped.indexOf('index.gts'),
-            stripped.lastIndexOf(`~~~${os.EOL}`) + 3
+            stripped.lastIndexOf(`~~~${os.EOL}`) + 3,
           );
           expect(error).toMatchInlineSnapshot(`
             "index.gts:15:5 - error TS2554: Expected 0 arguments, but got 1.
@@ -501,7 +501,7 @@ describe.skip('CLI: watched build mode typechecking', () => {
           let stripped = stripAnsi(output);
           let error = stripped.slice(
             stripped.indexOf('index.gts'),
-            stripped.lastIndexOf(`~~~${os.EOL}`) + 3
+            stripped.lastIndexOf(`~~~${os.EOL}`) + 3,
           );
           expect(error).toMatchInlineSnapshot(`
             "index.gts:3:28 - error TS2554: Expected 0 arguments, but got 1.
@@ -534,7 +534,7 @@ describe.skip('CLI: watched build mode typechecking', () => {
           let stripped = stripAnsi(output);
           let error = stripped.slice(
             stripped.indexOf('index.gts'),
-            stripped.lastIndexOf(`~~~${os.EOL}`) + 3
+            stripped.lastIndexOf(`~~~${os.EOL}`) + 3,
           );
           expect(error).toMatchInlineSnapshot(`
             "index.gts:3:27 - error TS2345: Argument of type 'string' is not assignable to parameter of type 'number'.

diff --git a/packages/core/__tests__/cli/build.test.ts b/packages/core/__tests__/cli/build.test.ts
@@ -1307,7 +1307,7 @@ describe.skip('CLI: --build --dry', () => {
       let buildResult = await project.build({ flags: ['--dry'] });
       expect(buildResult.exitCode).toBe(0);
       expect(stripAnsi(buildResult.stdout)).toMatch(
-        `A non-dry build would build project '${project.filePath('tsconfig.json')}'`
+        `A non-dry build would build project '${project.filePath('tsconfig.json')}'`,
       );
       expect(buildResult.stderr).toEqual('');
     });
@@ -1321,7 +1321,7 @@ describe.skip('CLI: --build --dry', () => {
         let buildResult = await project.build({ flags: ['--dry'] });
         expect(buildResult.exitCode).toBe(0);
         expect(stripAnsi(buildResult.stdout)).toMatch(
-          `Project '${project.filePath('tsconfig.json')}' is up to date`
+          `Project '${project.filePath('tsconfig.json')}' is up to date`,
         );
         expect(buildResult.stderr).toEqual('');
       });
@@ -1350,7 +1350,7 @@ describe.skip('CLI: --build --dry', () => {
         let buildResult = await project.build({ flags: ['--dry'] });
         expect(buildResult.exitCode).toBe(0);
         expect(stripAnsi(buildResult.stdout)).toMatch(
-          `A non-dry build would build project '${project.filePath('tsconfig.json')}'`
+          `A non-dry build would build project '${project.filePath('tsconfig.json')}'`,
         );
         expect(buildResult.stderr).toEqual('');
       });
@@ -1391,7 +1391,7 @@ describe.skip('CLI: --build --dry', () => {
       let buildResult = await project.build({ flags: ['--dry'] });
       expect(buildResult.exitCode).toBe(0);
       expect(stripAnsi(buildResult.stdout)).toMatch(
-        `A non-dry build would build project '${project.filePath('tsconfig.json')}'`
+        `A non-dry build would build project '${project.filePath('tsconfig.json')}'`,
       );
       expect(buildResult.stderr).toEqual('');
     });
@@ -1405,7 +1405,7 @@ describe.skip('CLI: --build --dry', () => {
         let buildResult = await project.build({ flags: ['--dry'] });
         expect(buildResult.exitCode).toBe(0);
         expect(stripAnsi(buildResult.stdout)).toMatch(
-          `Project '${project.filePath('tsconfig.json')}' is up to date`
+          `Project '${project.filePath('tsconfig.json')}' is up to date`,
         );
         expect(buildResult.stderr).toEqual('');
       });
@@ -1429,7 +1429,7 @@ describe.skip('CLI: --build --dry', () => {
         let buildResult = await project.build({ flags: ['--dry'] });
         expect(buildResult.exitCode).toBe(0);
         expect(stripAnsi(buildResult.stdout)).toMatch(
-          `A non-dry build would build project '${project.filePath('tsconfig.json')}'`
+          `A non-dry build would build project '${project.filePath('tsconfig.json')}'`,
         );
         expect(buildResult.stderr).toEqual('');
       });
@@ -1445,7 +1445,7 @@ describe.skip('CLI: --build --dry', () => {
         let buildResult = await project.build({ flags: ['--dry'] });
         expect(buildResult.exitCode).toBe(0);
         expect(stripAnsi(buildResult.stdout)).toMatch(
-          `A non-dry build would build project '${project.filePath('tsconfig.json')}'`
+          `A non-dry build would build project '${project.filePath('tsconfig.json')}'`,
         );
         expect(buildResult.stderr).toEqual('');
       }, 2_000_000);
@@ -1502,16 +1502,16 @@ describe.skip('CLI: --build --dry', () => {
       let buildResult = await projects.root.build({ flags: ['--dry'] });
       expect(buildResult.exitCode).toBe(0);
       expect(stripAnsi(buildResult.stdout)).toMatch(
-        `A non-dry build would build project '${projects.main.filePath('tsconfig.json')}'`
+        `A non-dry build would build project '${projects.main.filePath('tsconfig.json')}'`,
       );
       expect(stripAnsi(buildResult.stdout)).toMatch(
-        `A non-dry build would build project '${projects.children.a.filePath('tsconfig.json')}'`
+        `A non-dry build would build project '${projects.children.a.filePath('tsconfig.json')}'`,
       );
       expect(stripAnsi(buildResult.stdout)).toMatch(
-        `A non-dry build would build project '${projects.children.b.filePath('tsconfig.json')}'`
+        `A non-dry build would build project '${projects.children.b.filePath('tsconfig.json')}'`,
       );
       expect(stripAnsi(buildResult.stdout)).toMatch(
-        `A non-dry build would build project '${projects.children.c.filePath('tsconfig.json')}'`
+        `A non-dry build would build project '${projects.children.c.filePath('tsconfig.json')}'`,
       );
       expect(buildResult.stderr).toEqual('');
     });
@@ -1525,16 +1525,16 @@ describe.skip('CLI: --build --dry', () => {
         let buildResult = await projects.root.build({ flags: ['--dry'] });
         expect(buildResult.exitCode).toBe(0);
         expect(stripAnsi(buildResult.stdout)).toMatch(
-          `Project '${projects.main.filePath('tsconfig.json')}' is up to date`
+          `Project '${projects.main.filePath('tsconfig.json')}' is up to date`,
         );
         expect(stripAnsi(buildResult.stdout)).toMatch(
-          `Project '${projects.children.a.filePath('tsconfig.json')}' is up to date`
+          `Project '${projects.children.a.filePath('tsconfig.json')}' is up to date`,
         );
         expect(stripAnsi(buildResult.stdout)).toMatch(
-          `Project '${projects.children.b.filePath('tsconfig.json')}' is up to date`
+          `Project '${projects.children.b.filePath('tsconfig.json')}' is up to date`,
         );
         expect(stripAnsi(buildResult.stdout)).toMatch(
-          `Project '${projects.children.c.filePath('tsconfig.json')}' is up to date`
+          `Project '${projects.children.c.filePath('tsconfig.json')}' is up to date`,
         );
         expect(buildResult.stderr).toEqual('');
       });
@@ -1564,16 +1564,16 @@ describe.skip('CLI: --build --dry', () => {
           let buildResult = await projects.root.build({ flags: ['--dry'] });
           expect(buildResult.exitCode).toBe(0);
           expect(stripAnsi(buildResult.stdout)).toMatch(
-            `A non-dry build would build project '${projects.main.filePath('tsconfig.json')}'`
+            `A non-dry build would build project '${projects.main.filePath('tsconfig.json')}'`,
           );
           expect(stripAnsi(buildResult.stdout)).toMatch(
-            `Project '${projects.children.a.filePath('tsconfig.json')}' is up to date`
+            `Project '${projects.children.a.filePath('tsconfig.json')}' is up to date`,
           );
           expect(stripAnsi(buildResult.stdout)).toMatch(
-            `Project '${projects.children.b.filePath('tsconfig.json')}' is up to date`
+            `Project '${projects.children.b.filePath('tsconfig.json')}' is up to date`,
           );
           expect(stripAnsi(buildResult.stdout)).toMatch(
-            `Project '${projects.children.c.filePath('tsconfig.json')}' is up to date`
+            `Project '${projects.children.c.filePath('tsconfig.json')}' is up to date`,
           );
           expect(buildResult.stderr).toEqual('');
         });
@@ -1589,16 +1589,16 @@ describe.skip('CLI: --build --dry', () => {
           let buildResult = await projects.root.build({ flags: ['--dry'] });
           expect(buildResult.exitCode).toBe(0);
           expect(stripAnsi(buildResult.stdout)).toMatch(
-            `A non-dry build would build project '${projects.main.filePath('tsconfig.json')}'`
+            `A non-dry build would build project '${projects.main.filePath('tsconfig.json')}'`,
           );
           expect(stripAnsi(buildResult.stdout)).toMatch(
-            `A non-dry build would build project '${projects.children.a.filePath('tsconfig.json')}'`
+            `A non-dry build would build project '${projects.children.a.filePath('tsconfig.json')}'`,
           );
           expect(stripAnsi(buildResult.stdout)).toMatch(
-            `Project '${projects.children.b.filePath('tsconfig.json')}' is up to date`
+            `Project '${projects.children.b.filePath('tsconfig.json')}' is up to date`,
           );
           expect(stripAnsi(buildResult.stdout)).toMatch(
-            `Project '${projects.children.c.filePath('tsconfig.json')}' is up to date`
+            `Project '${projects.children.c.filePath('tsconfig.json')}' is up to date`,
           );
           expect(buildResult.stderr).toEqual('');
         });

diff --git a/packages/core/__tests__/cli/check.test.ts b/packages/core/__tests__/cli/check.test.ts
@@ -245,7 +245,7 @@ describe('CLI: single-pass typechecking', () => {
       'my-component.gts',
       stripIndent`
         export let x: string = 123;
-      `
+      `,
     );
 
     let checkResult = await project.check({ reject: false });