Elevation component changes #4226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
🦋 Changeset detectedLatest commit: d807bfe The changes in this PR will be included in the next version bump. This PR includes changesets to release 19 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
added
Type: Documentation
|
View your CI Pipeline Execution ↗ for commit d807bfe.
☁️ Nx Cloud last updated this comment at |
|
Size Change: +192 B (0%) Total Size: 1.12 MB
ℹ️ View Unchanged
|
serifluous
reviewed
Feb 19, 2025
| @@ -15,11 +15,9 @@ const StyledTooltip = React.forwardRef<HTMLDivElement, BoxProps>(({ style, eleme | |||
| return ( | |||
| <Box | |||
| {...safelySpreadBoxProps(props)} | |||
| backgroundColor="colorBackgroundBodyInverse" | |||
| backgroundColor="colorBackgroundInverseElevation" | |||
| boxShadow="shadowElevationInverse10" | |||
There was a problem hiding this comment.
question: @roxanagomez Is there any way we can lighten shadowElevationInverse10? It looks a little severe on light backgrounds.
There was a problem hiding this comment.
Yes for sure, i was always a little insecure about it. I updated just the second shadow color token from black-transparent-40 to black-transparent-10.
Shadow 1 (border)
hex: gray-90
X:0 y:offset-negative-05 b: 0
Shadow 2 (distance)
hex: black-transparent-10
x: 0 y: offset-15 b: offset-20
cc @PixeledCode
serifluous
previously approved these changes
Feb 20, 2025
serifluous
previously approved these changes
Feb 28, 2025
krisantrobus
approved these changes
Mar 3, 2025
roxanagomez
approved these changes
Mar 3, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.