Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change scss form checked variables to css variables for easy overwrite checkbox color #41161

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

FrancoJFerreyra
Copy link

Description

Change the values ​​of the form checked variables from $form-check-input-checked-bg-color and $form-check-input-checked-border-color to --#{$prefix}form-check-input-checked -bg-color and --#{$prefix}form-check-input-checked-border-color) by adding these to the _root.scss and _form-check.scss file.

Motivation & Context

Resolve issue #41137. #41137

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Live previews

No live preview

Related issues

#41137

…put-checked-bg-color and $form-check-input-checked-border-color to --#{$prefix}form-check-input-checked -bg-color and --#{$prefix}form-check-input-checked-border-color) by adding these to the _root.scss and _form-check.scss file.

Resolve issue twbs#41137. twbs#41137

- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds functionality)
- [ ] Refactoring (non-breaking change)
- [ ] Breaking change (fix or feature that would change existing functionality)

- [x] I have read the [contributing guidelines](https://github.com/twbs/bootstrap/blob/main/.github/CONTRIBUTING.md)
- [x] My code follows the code style of the project _(using `npm run lint`)_
- [ ] My change introduces changes to the documentation
- [ ] I have updated the documentation accordingly
- [ ] I have added tests to cover my changes
- [ ] All new and existing tests passed

  No live preview

  twbs#41137
@FrancoJFerreyra FrancoJFerreyra requested a review from a team as a code owner January 18, 2025 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant