This repository has been archived by the owner on Feb 1, 2022. It is now read-only.
[v1] Remove various checks #426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Herst
force-pushed
the
next
branch
2 times, most recently
from
622ae8b to
65d8daf
Compare
Herst
force-pushed
the
next-remove-various-checks
branch
from
3ffe6ec to
6995251
Compare
Herst
force-pushed
the
next-remove-various-checks
branch
2 times, most recently
from
8229371 to
cb55f1d
Compare
Herst
force-pushed
the
next-remove-various-checks
branch
from
cb55f1d to
29de7b1
Compare
Herst
force-pushed
the
next-remove-various-checks
branch
4 times, most recently
from
b7971cf to
0f3a10b
Compare
* W002 (X-UA-Compatible) * W010 (.pull-left or .pull-right in .media) * W015 (Bootstrap 4) * E002 (Bootstrap v2 grid) * E030 (.glyphicon-* without .glyphicon) * E031 (.glyphicon on element with content or children) * E038 (.media-left/.media-right outside of .media)
Herst
force-pushed
the
next-remove-various-checks
branch
from
0f3a10b to
2adeab0
Compare
66 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
W002 (X-UA-Compatible)
W010 (.pull-left or .pull-right in .media)
W015 (Bootstrap 4)
E002 (Bootstrap v2 grid)
E030 (.glyphicon-* without .glyphicon)
E031 (.glyphicon on element with content or
children)
E038 (.media-left/.media-right outside of
.media)
The media stuff I removed because both checks are irrelevant right now, that said, it might be worth adding new checks for media (#424).
Bootstrap 2 check was removed because I doubt anyone is going to switch from Bootstrap 2 to Bootstrap 4+.
The rest should be obvious.
Status