Jsonb support update #1207
Merged
Jsonb support update #1207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ihorandrianov
requested review from
jussisaurio,
pereman2 and
penberg
as code owners
penberg
reviewed
Mar 28, 2025
| fs = ["limbo_ext/vfs"] | ||
| json = ["dep:jsonb", "dep:pest", "dep:pest_derive", "dep:serde", "dep:indexmap"] |
There was a problem hiding this comment.
We do want to keep the feature flag to allow people to build Limbo without JSON support, similar to what SQLite allows with the SQLITE_ENABLE_JSON build option.
There was a problem hiding this comment.
@penberg Yes, my bad, fixed
ihorandrianov
force-pushed
the
jsonb_merge69
branch
from
9bc67de to
a234aa3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Can wait for immutable record merge, if it will happen in near future.