Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update node20.json to match the same semver as the other nodes #205

Merged
merged 1 commit into from
Jul 14, 2023

Conversation

orta
Copy link
Member

@orta orta commented Jul 14, 2023

#202 noted that the versioning was off, this migrates node20 inline with the rest of the bases

@orta orta enabled auto-merge July 14, 2023 21:52
@orta orta merged commit 53d80ed into main Jul 14, 2023
@jakebailey
Copy link

Maybe I missed the discussion for the new versioning, but what happens if we need to make a breaking change to these again? It seems awkward to have to bump node20 at v20 to... v21. Before, at least they were unrelated.

@orta
Copy link
Member Author

orta commented Jul 14, 2023

Had to make a decision back during the big breaks in #197 and as we already had one or two using this format opted to make them consistent with that - agree its meh, but any change is likely a break

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants