-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: tooltip & hover color schemes #414
base: main
Are you sure you want to change the base?
Conversation
Removed api key from dashboard
Added pay-as-you-go
* Added progress * Added progress * Added future * Added about * Updated icons and open source section * Added inventory hero * Small tweaks * Added code with * Styling on the haters * Added videos --------- Co-authored-by: brycedli <[email protected]>
* chore: update changelog & version info * fixes --------- Co-authored-by: Himanshu <[email protected]>
…pear#405) (trypear#406) * fix(form): resolve color coding issue in 'Windows' form dropdown (trypear#405) * fix: corrected mistakes in PR
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@MohammedADev is attempting to deploy a commit to the PearAI Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Reviewed everything up to b0ad025 in 43 seconds
More details
- Looked at
27
lines of code in2
files - Skipped
0
files when reviewing. - Skipped posting
4
drafted comments based on config settings.
1. components/ui/button.tsx:27
- Draft comment:
Ensure that updating the ghost variant's hover background to 'hover:bg-secondary-300/10' is intentional and aligns with design guidelines. - Reason this comment was not posted:
Marked as duplicate.
2. components/ui/tooltip.tsx:26
- Draft comment:
Verify that the updated tooltip styling with 'bg-background' and 'text-accent-foreground' provides sufficient contrast and is consistent with the overall theme. - Reason this comment was not posted:
Marked as duplicate.
3. components/ui/button.tsx:26
- Draft comment:
Ensure the ghost variant's hover background change from 'bg-accent' to 'bg-secondary-300/10' is intentional per the new design. Verify that this variant remains consistent with overall UI guidelines. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%
<= threshold50%
The comment is asking the PR author to confirm their intention and verify consistency with UI guidelines, which violates the rules. It does not provide a specific code suggestion or ask for a specific test to be written.
4. components/ui/tooltip.tsx:26
- Draft comment:
The tooltip content now uses 'bg-background' and 'text-accent-foreground' instead of 'bg-popover' and 'text-popover-foreground'. Confirm that these changes preserve sufficient contrast and match the intended theme. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%
<= threshold50%
The comment is asking the PR author to confirm that the changes preserve sufficient contrast and match the intended theme. This is asking for confirmation of intention, which violates the rules. The comment does not provide a specific suggestion or point out a clear issue with the code.
Workflow ID: wflow_qN7kHLQ2DgrNqFc3
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
Description
changed to correct color scheme
Related Issue
Changes Made
Screenshots
before
after
Checklist
yarn build
and build is successfulImportant
Update tooltip and button hover color schemes in
button.tsx
andtooltip.tsx
.button.tsx
, updatedghost
variant to usehover:bg-secondary-300/10
for hover background color.tooltip.tsx
, changedTooltipContent
background color tobg-background
and text color totext-accent-foreground
.This description was created by
for b0ad025. It will automatically update as commits are pushed.