Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: tooltip & hover color schemes #414

Open
wants to merge 22 commits into
base: main
Choose a base branch
from

Conversation

MohammedADev
Copy link
Contributor

@MohammedADev MohammedADev commented Feb 15, 2025

Description

changed to correct color scheme

Related Issue

Changes Made

Screenshots

before

image
image
image

after

image
image
image

Checklist

  • I have tagged the issue in this PR.
  • I have attached necessary screenshots.
  • I have provided a short description of the PR.
  • I ran yarn build and build is successful
  • My code follows the style guidelines of this project.
  • I have added necessary documentation (if applicable)

Important

Update tooltip and button hover color schemes in button.tsx and tooltip.tsx.

  • Color Scheme Updates:
    • In button.tsx, updated ghost variant to use hover:bg-secondary-300/10 for hover background color.
    • In tooltip.tsx, changed TooltipContent background color to bg-background and text color to text-accent-foreground.

This description was created by Ellipsis for b0ad025. It will automatically update as commits are pushed.

Copy link

vercel bot commented Feb 15, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
pear-landing-page ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 18, 2025 2:17am
pear-landing-page-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 18, 2025 2:17am

Copy link

vercel bot commented Feb 15, 2025

@MohammedADev is attempting to deploy a commit to the PearAI Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to b0ad025 in 43 seconds

More details
  • Looked at 27 lines of code in 2 files
  • Skipped 0 files when reviewing.
  • Skipped posting 4 drafted comments based on config settings.
1. components/ui/button.tsx:27
  • Draft comment:
    Ensure that updating the ghost variant's hover background to 'hover:bg-secondary-300/10' is intentional and aligns with design guidelines.
  • Reason this comment was not posted:
    Marked as duplicate.
2. components/ui/tooltip.tsx:26
  • Draft comment:
    Verify that the updated tooltip styling with 'bg-background' and 'text-accent-foreground' provides sufficient contrast and is consistent with the overall theme.
  • Reason this comment was not posted:
    Marked as duplicate.
3. components/ui/button.tsx:26
  • Draft comment:
    Ensure the ghost variant's hover background change from 'bg-accent' to 'bg-secondary-300/10' is intentional per the new design. Verify that this variant remains consistent with overall UI guidelines.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50%
    The comment is asking the PR author to confirm their intention and verify consistency with UI guidelines, which violates the rules. It does not provide a specific code suggestion or ask for a specific test to be written.
4. components/ui/tooltip.tsx:26
  • Draft comment:
    The tooltip content now uses 'bg-background' and 'text-accent-foreground' instead of 'bg-popover' and 'text-popover-foreground'. Confirm that these changes preserve sufficient contrast and match the intended theme.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50%
    The comment is asking the PR author to confirm that the changes preserve sufficient contrast and match the intended theme. This is asking for confirmation of intention, which violates the rules. The comment does not provide a specific suggestion or point out a clear issue with the code.

Workflow ID: wflow_qN7kHLQ2DgrNqFc3


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants