RSpec quarantining support #484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
😎 Merged successfully - details. |
gnalh
force-pushed
the
gabe/trunk-14369-support-quarantining-within-rspec-plugin
branch
from
4718fef to
04817c9
Compare
1 similar comment
gnalh
force-pushed
the
gabe/trunk-14369-support-quarantining-within-rspec-plugin
branch
4 times, most recently
from
dad5cce to
5c6b9ba
Compare
gnalh
force-pushed
the
gabe/trunk-14369-support-quarantining-within-rspec-plugin
branch
from
5c6b9ba to
ac5789a
Compare
gnalh
force-pushed
the
gabe/trunk-14369-support-quarantining-within-rspec-plugin
branch
4 times, most recently
from
3c3380e to
7903788
Compare
gnalh
commented
Mar 26, 2025
| @@ -66,9 +66,7 @@ pub struct TelemetryUploadMetricsRequest { | |||
|
|
|||
| #[derive(Debug, Serialize, Clone, Deserialize, PartialEq)] | |||
| pub struct PageQuery { | |||
There was a problem hiding this comment.
The api updated the names before release.
gnalh
force-pushed
the
gabe/trunk-14369-support-quarantining-within-rspec-plugin
branch
from
7903788 to
6fd6090
Compare
gnalh
force-pushed
the
gabe/trunk-14369-support-quarantining-within-rspec-plugin
branch
3 times, most recently
from
f3da1c2 to
6e8419e
Compare
gnalh
commented
Mar 26, 2025
| @@ -230,7 +342,6 @@ impl MutTestReport { | |||
| Status::Skipped => test.status = TestCaseRunStatus::Skipped.into(), | |||
| Status::Unspecified => test.status = TestCaseRunStatus::Unspecified.into(), | |||
| } | |||
| // test.status = status; | |||
There was a problem hiding this comment.
This is extraneous, we set it above.
gnalh
force-pushed
the
gabe/trunk-14369-support-quarantining-within-rspec-plugin
branch
from
6e8419e to
f23d8c5
Compare
cmillar-trunk
approved these changes
Mar 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.